dash/doc/release-notes-pr13381.md
Jonas Schnelli cabaeaa2fc Merge #13381: RPC: creates possibility to preserve labels on importprivkey
a6b5ec18f rpc: creates possibility to preserve labels on importprivkey (marcoagner)

Pull request description:

  Closes #13087.

  As discussed in the issue, this is a feature request instead of a bug report since the behaviour was as intended (i.e. label with default: `''`). With this, the old behaviour is kept while the possibility to achieve the preservation of labels, as expected in the open issue, is added.

Tree-SHA512: b33be50e1e7f62f7ddfae953177ba0926e2d848961f9fac7501c2b513322c0cb95787745d07d137488267bad1104ecfdbe800c6747f94162eb07c976835c1386
2022-03-08 00:46:09 -05:00

1.3 KiB

RPC importprivkey: new label behavior

Previously, importprivkey automatically added the default empty label ("") to all addresses associated with the imported private key. Now it defaults to using any existing label for those addresses. For example:

  • Old behavior: you import a watch-only address with the label "cold wallet". Later, you import the corresponding private key using the default settings. The address's label is changed from "cold wallet" to "".

  • New behavior: you import a watch-only address with the label "cold wallet". Later, you import the corresponding private key using the default settings. The address's label remains "cold wallet".

In both the previous and current case, if you directly specify a label during the import, that label will override whatever previous label the addresses may have had. Also in both cases, if none of the addresses previously had a label, they will still receive the default empty label (""). Examples:

  • You import a watch-only address with the label "temporary". Later you import the corresponding private key with the label "final". The address's label will be changed to "final".

  • You use the default settings to import a private key for an address that was not previously in the wallet. Its addresses will receive the default empty label ("").