mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
11f67cba23
## Issue being fixed or feature implemented Currently template for "New pull request" have a lot of instruction that are formatted as comments by html/markdown tag. It makes this instruction to append in the final commit message when pull request is merged because they are invisible for reviewer (marked as comment). With new template the messages would be more likely to be cleaned up before merging. ## What was done? Replaced commented text in template to cursive test (italic) ## How Has This Been Tested? By clicking "Preview" on GitHub ## Breaking Changes No breaking changes, it's trivial change ## Checklist: - [x] I have performed a self-review of my own code - [x] I have assigned this pull request to a milestone
53 lines
2.1 KiB
Markdown
53 lines
2.1 KiB
Markdown
***Please remove the italicized help prompts before submitting or merging***
|
|
|
|
_Provide a general summary of your changes in the Title above_
|
|
|
|
_Pull requests without a rationale and clear improvement may be closed
|
|
immediately._
|
|
|
|
_Please provide clear motivation for your patch and explain how it improves
|
|
Dash Core user experience or Dash Core developer experience
|
|
significantly:_
|
|
|
|
* _Any test improvements or new tests that improve coverage are always welcome._
|
|
* _All other changes should have accompanying unit tests (see `src/test/`) or
|
|
functional tests (see `test/`). Contributors should note which tests cover
|
|
modified code. If no tests exist for a region of modified code, new tests
|
|
should accompany the change._
|
|
* _Bug fixes are most welcome when they come with steps to reproduce or an
|
|
explanation of the potential issue as well as reasoning for the way the bug
|
|
was fixed._
|
|
* _Features are welcome, but might be rejected due to design or scope issues.
|
|
If a feature is based on a lot of dependencies, contributors should first
|
|
consider building the system outside of Dash Core, if possible._
|
|
|
|
|
|
## Issue being fixed or feature implemented
|
|
- _Why is this change required? What problem does it solve?_
|
|
- _If it fixes an open issue, please link to the issue here._
|
|
|
|
|
|
## What was done?
|
|
_Describe your changes in detail_
|
|
|
|
|
|
## How Has This Been Tested?
|
|
_Please describe in detail how you tested your changes._
|
|
|
|
_Include details of your testing environment, and the tests you ran
|
|
to see how your change affects other areas of the code, etc._
|
|
|
|
|
|
## Breaking Changes
|
|
_Please describe any breaking changes your code introduces_
|
|
|
|
|
|
## Checklist:
|
|
_Go over all the following points, and put an `x` in all the boxes that apply._
|
|
- [ ] I have performed a self-review of my own code
|
|
- [ ] I have commented my code, particularly in hard-to-understand areas
|
|
- [ ] I have added or updated relevant unit/integration/functional/e2e tests
|
|
- [ ] I have made corresponding changes to the documentation
|
|
- [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
|
|
|