mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
2da9982e55
aaaaad6ac95b402fe18d019d67897ced6b316ee0 scripted-diff: Bump copyright of files changed in 2019 (MarcoFalke)
Pull request description:
ACKs for top commit:
practicalswift:
ACK aaaaad6ac95b402fe18d019d67897ced6b316ee0
promag:
ACK aaaaad6ac95b402fe18d019d67897ced6b316ee0 🎉
fanquake:
ACK aaaaad6ac95b402fe18d019d67897ced6b316ee0 - going to merge this now because the year is over and conflicts are minimal.
Tree-SHA512: 58cb1f53bc4c1395b2766f36fabc7e2332e213780a802762fff0afd59468dad0c3265f553714d761c7a2c44ff90f7dc250f04458f4b2eb8eef8b94f8c9891321
75 lines
3.2 KiB
C++
75 lines
3.2 KiB
C++
// Copyright (c) 2017-2019 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <version.h>
|
|
|
|
#include <consensus/consensus.h>
|
|
#include <consensus/tx_check.h>
|
|
|
|
#include <primitives/transaction.h>
|
|
#include <consensus/validation.h>
|
|
|
|
bool CheckTransaction(const CTransaction& tx, TxValidationState& state)
|
|
{
|
|
bool allowEmptyTxIn = false;
|
|
bool allowEmptyTxOut = false;
|
|
if (tx.nType == TRANSACTION_QUORUM_COMMITMENT || tx.nType == TRANSACTION_MNHF_SIGNAL) {
|
|
allowEmptyTxIn = true;
|
|
allowEmptyTxOut = true;
|
|
}
|
|
if (tx.nType == TRANSACTION_ASSET_UNLOCK) {
|
|
allowEmptyTxIn = true;
|
|
}
|
|
|
|
// Basic checks that don't depend on any context
|
|
if (!allowEmptyTxIn && tx.vin.empty())
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-vin-empty");
|
|
if (!allowEmptyTxOut && tx.vout.empty())
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-vout-empty");
|
|
// Size limits
|
|
if (::GetSerializeSize(tx, PROTOCOL_VERSION) > MAX_LEGACY_BLOCK_SIZE)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-oversize");
|
|
if (tx.vExtraPayload.size() > MAX_TX_EXTRA_PAYLOAD)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-payload-oversize");
|
|
|
|
// Check for negative or overflow output values (see CVE-2010-5139)
|
|
CAmount nValueOut = 0;
|
|
for (const auto& txout : tx.vout) {
|
|
if (txout.nValue < 0)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-vout-negative");
|
|
if (txout.nValue > MAX_MONEY)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-vout-toolarge");
|
|
nValueOut += txout.nValue;
|
|
if (!MoneyRange(nValueOut))
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-txouttotal-toolarge");
|
|
}
|
|
|
|
// Check for duplicate inputs (see CVE-2018-17144)
|
|
// While Consensus::CheckTxInputs does check if all inputs of a tx are available, and UpdateCoins marks all inputs
|
|
// of a tx as spent, it does not check if the tx has duplicate inputs.
|
|
// Failure to run this check will result in either a crash or an inflation bug, depending on the implementation of
|
|
// the underlying coins database.
|
|
std::set<COutPoint> vInOutPoints;
|
|
for (const auto& txin : tx.vin) {
|
|
if (!vInOutPoints.insert(txin.prevout).second)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-inputs-duplicate");
|
|
}
|
|
|
|
if (tx.IsCoinBase()) {
|
|
size_t minCbSize = 2;
|
|
if (tx.nType == TRANSACTION_COINBASE) {
|
|
// With the introduction of CbTx, coinbase scripts are not required anymore to hold a valid block height
|
|
minCbSize = 1;
|
|
}
|
|
if (tx.vin[0].scriptSig.size() < minCbSize || tx.vin[0].scriptSig.size() > 100)
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-cb-length");
|
|
} else {
|
|
for (const auto& txin : tx.vin)
|
|
if (txin.prevout.IsNull())
|
|
return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-prevout-null");
|
|
}
|
|
|
|
return true;
|
|
}
|