dash/test/functional
pasta 8a86fd898e
Merge #6416: refactor: drop unused parameter mninfos_valid in test framework mine_ cycle_quorum
0072318421 refactor: drop unused parameter mninfos_valid in test framework mine_cycle_quorum (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  This param is unused

  ## What was done?
  Removed

  ## How Has This Been Tested?
  see ci

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK 0072318421
  UdjinM6:
    utACK 0072318421

Tree-SHA512: e66e2b23b95b98e843fdb1d58419ba0798e8ba4115ef6c52e2e4681b04ea3e43efe73cee0ac96758560914567f822d107169ca0d6212210e07cc81b317a3e2eb
2024-11-20 11:34:21 -06:00
..
data test: drop genesis block from blockheader_testnet3 2024-08-09 17:34:40 +07:00
test_framework refactor: drop unused parameter mninfos_valid in test framework mine_cycle_quorum 2024-11-19 23:10:21 -06:00
.gitignore
combine_logs.py
combined_log_template.html
create_cache.py
example_test.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
feature_abortnode.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
feature_addressindex.py feat: only require reindexing when the index was off going to off 2024-10-24 12:50:15 -05:00
feature_addrman.py Merge bitcoin/bitcoin#24312: addrman: Log too low compat value 2024-11-17 17:49:40 -06:00
feature_anchors.py Merge bitcoin/bitcoin#26314: test: perturb anchors.dat to test error during initialization 2024-10-25 09:59:34 -05:00
feature_asmap.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_asset_locks.py test: update feature_asset_locks.py to reflect changes 2024-10-29 12:57:35 -05:00
feature_assumevalid.py
feature_backwards_compatibility.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_bind_extra.py Merge bitcoin/bitcoin#25333: test: Fix out-of-range port collisions 2024-06-08 20:59:34 -05:00
feature_bind_port_discover.py merge bitcoin#20196: fix GetListenPort() to derive the proper port 2024-06-12 16:37:12 +00:00
feature_bind_port_externalip.py merge bitcoin#20196: fix GetListenPort() to derive the proper port 2024-06-12 16:37:12 +00:00
feature_bip68_sequence.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
feature_block.py Merge bitcoin/bitcoin#22378: test: remove confusing MAX_BLOCK_BASE_SIZE 2024-10-25 20:51:19 +07:00
feature_blocksdir.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_cltv.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_coinstatsindex.py Merge bitcoin/bitcoin#30340: test: Added coverage to Block not found error using gettxoutsetinfo 2024-10-26 19:14:06 -05:00
feature_config_args.py Merge #6357: backport: bitcoin/bitcoin#22229 test: consolidate to f-strings and related fixes 2024-10-25 15:49:53 -05:00
feature_csv_activation.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_dbcrash.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_dersig.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_dip3_deterministicmns.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_dip3_v19.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_dip4_coinbasemerkleroots.py refactor: Refactor CCbTx python class to match c++ declaration 2024-11-02 00:19:06 +03:00
feature_dirsymlinks.py Merge bitcoin/bitcoin#24381: test: Run symlink regression tests on Windows 2024-10-15 09:25:09 -05:00
feature_discover.py Merge bitcoin/bitcoin#24269: test: add functional test for -discover 2024-06-10 11:00:46 -05:00
feature_fee_estimation.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_filelock.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_governance_cl.py test: cleanup generate logic in some governance functional tests 2024-10-04 19:01:05 +00:00
feature_governance_objects.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
feature_governance.py merge bitcoin#28645: fix assert_debug_log call-site bugs, add type checks 2024-10-16 16:50:55 +00:00
feature_help.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_includeconf.py
feature_index_prune.py merge bitcoin#26417: fix intermittent failure in feature_index_prune.py 2024-10-15 06:58:52 +00:00
feature_init.py Merge bitcoin/bitcoin#26653: test, init: perturb file to ensure failure instead of only deleting them 2024-10-25 09:59:35 -05:00
feature_llmq_chainlocks.py fix: functional test feature_llmq_chainlocks.py should activate MN_RR instead v20 2024-11-20 03:20:50 +07:00
feature_llmq_connections.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
feature_llmq_data_recovery.py test: opt-out of post-generate* syncing in some Dash tests 2024-10-04 19:01:05 +00:00
feature_llmq_dkgerrors.py rpc: switch to taking an integer for rate in quorum dkgsimerror 2024-10-08 15:58:58 +00:00
feature_llmq_evo.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_llmq_is_cl_conflicts.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_llmq_is_retroactive.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
feature_llmq_rotation.py refactor: Refactor CCbTx python class to match c++ declaration 2024-11-02 00:19:06 +03:00
feature_llmq_signing.py refactor: drop fast_dip3_enforcement=True from functional tests. 2024-09-26 14:17:05 +07:00
feature_llmq_simplepose.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_loadblock.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_logging.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_maxuploadtarget.py merge bitcoin#29358: use v2 everywhere for P2PConnection if --v2transport is enabled 2024-10-24 14:32:04 +00:00
feature_minchainwork.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_mnehf.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
feature_multikeysporks.py Merge #19816: test: Rename wait until helper to wait_until_helper 2024-03-06 02:00:39 +07:00
feature_new_quorum_type_activation.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
feature_notifications.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_nulldummy.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
feature_proxy.py Merge bitcoin/bitcoin#24258: test: check localaddresses in getnetworkinfo for nodes with proxy 2024-06-11 12:09:21 -05:00
feature_pruning.py Merge #6357: backport: bitcoin/bitcoin#22229 test: consolidate to f-strings and related fixes 2024-10-25 15:49:53 -05:00
feature_reindex.py merge bitcoin#24748: functional tests for v2 P2P encryption 2024-10-24 14:32:03 +00:00
feature_settings.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
feature_shutdown.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
feature_spentindex.py feat: only require reindexing when the index was off going to off 2024-10-24 12:50:15 -05:00
feature_sporks.py test: should have no spork with an empty name 2024-10-16 13:30:51 +03:00
feature_startupnotify.py Merge bitcoin/bitcoin#26818: test: Fix feature_startupnotify intermittent issue 2024-08-12 11:52:39 +07:00
feature_timestampindex.py feat: only require reindexing when the index was off going to off 2024-10-24 12:50:15 -05:00
feature_txindex_compatibility.py merge bitcoin#23046: Add txindex migration test 2024-10-15 06:58:49 +00:00
feature_txindex.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
feature_uacomment.py
feature_utxo_set_hash.py Merge bitcoin/bitcoin#29399: test: Fix utxo set hash serialisation signedness 2024-10-24 11:16:19 -05:00
feature_versionbits_warning.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
interface_bitcoin_cli.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
interface_http.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
interface_rest.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
interface_rpc.py Merge bitcoin/bitcoin#22229: test: consolidate to f-strings (part 1) 2024-10-25 21:24:00 +07:00
interface_usdt_net.py merge bitcoin#24358: USDT tracepoint interface tests 2024-09-04 18:46:14 +00:00
interface_usdt_utxocache.py Merge bitcoin/bitcoin#25486: test: fix failing test interface_usdt_utxocache.py 2024-10-25 09:13:05 -05:00
interface_usdt_validation.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
interface_zmq_dash.py fix: use unique port for interface_zmq_dash.py - follow-up for bitcoin/bitcoin#26805 2024-10-30 00:11:53 +07:00
interface_zmq.py Merge #6357: backport: bitcoin/bitcoin#22229 test: consolidate to f-strings and related fixes 2024-10-25 15:49:53 -05:00
mempool_accept.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_compatibility.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
mempool_expiry.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_limit.py merge bitcoin#22741: Add generate* calls to test framework 2024-10-04 19:00:57 +00:00
mempool_package_limits.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_package_onemore.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_packages.py Merge bitcoin/bitcoin#29948: test: add missing comparison of node1's mempool in MempoolPackagesTest 2024-10-26 12:29:52 -05:00
mempool_persist.py Merge bitcoin/bitcoin#23061: Fix (inverse) meaning of -persistmempool 2024-10-17 20:25:27 +05:30
mempool_reorg.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
mempool_resurrect.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_spend_coinbase.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mempool_unbroadcast.py Merge bitcoin/bitcoin#24749: test: use MiniWallet for mempool_unbroadcast.py 2024-10-15 09:25:09 -05:00
mempool_updatefromblock.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mining_basic.py Merge #6357: backport: bitcoin/bitcoin#22229 test: consolidate to f-strings and related fixes 2024-10-25 15:49:53 -05:00
mining_getblocktemplate_longpoll.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
mining_prioritisetransaction.py Merge bitcoin/bitcoin#22378: test: remove confusing MAX_BLOCK_BASE_SIZE 2024-10-25 20:51:19 +07:00
p2p_add_connections.py merge bitcoin#23774: Add missing assert_equal import to p2p_add_connections.py 2024-10-02 08:31:48 +00:00
p2p_addr_relay.py merge bitcoin#28632: make python p2p not send getaddr on incoming connections 2024-10-16 16:50:55 +00:00
p2p_addrfetch.py Merge bitcoin/bitcoin#22568: test: add addr-fetch peer connection state and timeout coverage 2024-08-29 08:07:41 +05:30
p2p_addrv2_relay.py merge bitcoin#23380: Fix AddrMan::Add() return semantics and logging 2024-06-10 17:16:38 +00:00
p2p_block_sync.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_blockfilters.py Merge bitcoin/bitcoin#28227: test: check for specific bip157 disconnect reasons, add test coverage 2024-10-24 11:18:40 -05:00
p2p_blocksonly.py merge bitcoin#25156: Introduce PeerManagerImpl::RejectIncomingTxs 2024-10-26 19:22:31 +00:00
p2p_compactblocks_blocksonly.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
p2p_compactblocks_hb.py Merge bitcoin/bitcoin#29893: test: fix intermittent failure in p2p_compactblocks_hb.py 2024-10-26 12:29:51 -05:00
p2p_compactblocks.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_connect_to_devnet.py non-scripted-diff: bump copyright year to 2023 2024-02-24 11:05:37 -06:00
p2p_disconnect_ban.py merge bitcoin#27128: fix intermittent issue in p2p_disconnect_ban 2024-10-02 08:31:48 +00:00
p2p_dos_header_tree.py Merge #16551: test: Test that low difficulty chain fork is rejected 2024-04-03 14:16:43 +07:00
p2p_eviction.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_filter.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_fingerprint.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_getaddr_caching.py Merge bitcoin/bitcoin#25333: test: Fix out-of-range port collisions 2024-06-08 20:59:34 -05:00
p2p_getdata.py
p2p_governance_invs.py test: add test for governance inv expiration 2024-08-22 22:03:48 +03:00
p2p_i2p_ports.py Merge bitcoin/bitcoin#29393: i2p: log connection was refused due to arbitrary port 2024-10-24 11:16:21 -05:00
p2p_i2p_sessions.py merge bitcoin#26838: I2P documentation updates 2024-05-29 11:48:38 -05:00
p2p_ibd_stalling.py Merge bitcoin/bitcoin#30705: test: Avoid intermittent block download timeout in p2p_ibd_stalling 2024-10-26 19:14:08 -05:00
p2p_ibd_txrelay.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
p2p_initial_headers_sync.py test: remove dead code from p2p_initial_headers_sync.py to favor of disable mocktime 2024-09-01 18:27:19 +07:00
p2p_instantsend.py test: remove redundant sync after generate* calls in Dash tests 2024-10-04 19:01:05 +00:00
p2p_invalid_block.py Merge bitcoin/bitcoin#28412: test: remove unused variables in p2p_invalid_block 2024-10-24 11:18:39 -05:00
p2p_invalid_locator.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_invalid_messages.py Merge #6351: backport: trivial 2024 10 23 pr8 2024-10-25 09:06:30 -05:00
p2p_invalid_tx.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_leak_tx.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
p2p_leak.py Merge bitcoin/bitcoin#22153: test: Fix p2p_leak.py intermittent failure 2024-10-24 16:34:25 +07:00
p2p_message_capture.py partial bitcoin#20196: fix GetListenPort() to derive the proper port 2024-04-26 20:25:31 +00:00
p2p_net_deadlock.py test: call self.generate() in p2p_net_deadlock.py 2024-10-05 09:41:53 +00:00
p2p_nobloomfilter_messages.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
p2p_node_network_limited.py merge bitcoin#28805: Make existing functional tests compatible with --v2transport 2024-10-15 15:34:12 +00:00
p2p_permissions.py Merge bitcoin/bitcoin#21562: [net processing] Various tidying up of PeerManagerImpl ctor 2024-10-25 20:51:18 +07:00
p2p_ping.py Merge #18638: net: Use mockable time for ping/pong, add tests 2024-07-08 23:57:01 +07:00
p2p_quorum_data.py test: move differing sync logic into sync_fun lambda in Dash tests 2024-10-04 19:01:05 +00:00
p2p_sendheaders_compressed.py test: opt-out of post-generate* syncing in some Dash tests 2024-10-04 19:01:05 +00:00
p2p_sendheaders.py test: remove redundant self.nodes from self.sync_{blocks,all} 2024-10-04 19:01:05 +00:00
p2p_sendtxrcncl.py merge bitcoin#26359: Erlay support signaling follow-ups 2024-10-27 19:38:30 +00:00
p2p_timeouts.py merge bitcoin#29358: use v2 everywhere for P2PConnection if --v2transport is enabled 2024-10-24 14:32:04 +00:00
p2p_tx_download.py Merge bitcoin/bitcoin#22257: test: refactor: various (de)serialization helpers cleanups/improvements 2024-03-22 10:29:15 -05:00
p2p_unrequested_blocks.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
p2p_v2_encrypted.py merge bitcoin#24748: functional tests for v2 P2P encryption 2024-10-24 14:32:03 +00:00
p2p_v2_misbehaving.py merge bitcoin#29431: disconnection scenarios during v2 handshake 2024-10-24 14:32:05 +00:00
p2p_v2_transport.py merge bitcoin#29460: assert rpc error for addnode v2transport not enabled 2024-10-24 14:32:04 +00:00
README.md Merge bitcoin/bitcoin#23001: doc: Enable TLS in links in documentation 2024-09-12 20:24:08 +05:30
rpc_addresses_deprecation.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
rpc_bind.py
rpc_blockchain.py Merge #6279: fix: new fork 'withdrawals' and fixes for asset unlock signature verification 2024-10-21 11:17:37 -05:00
rpc_coinjoin.py
rpc_createmultisig.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
rpc_decodescript.py Merge bitcoin#22593: remove hex_str_to_bytes helper 2024-08-25 07:55:20 +05:30
rpc_deprecated_platform_filter.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc_deprecated.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
rpc_deriveaddresses.py
rpc_dumptxoutset.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
rpc_estimatefee.py Merge bitcoin/bitcoin#27934: test: added coverage to estimatefee 2024-10-24 11:18:39 -05:00
rpc_external_queue.py partial Merge #20755: [rpc] Remove deprecated fields from getpeerinfo 2024-10-24 16:34:25 +07:00
rpc_fundrawtransaction.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
rpc_generate.py Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) 2024-03-17 13:02:58 -05:00
rpc_generateblock.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
rpc_getblockfilter.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
rpc_getblockfrompeer.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
rpc_getblockstats.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
rpc_getchaintips.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
rpc_getdescriptorinfo.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_getpeerinfo_deprecation.py partial Merge #20755: [rpc] Remove deprecated fields from getpeerinfo 2024-10-24 16:34:25 +07:00
rpc_help.py Merge #20012: rpc: Remove duplicate name and argNames from CRPCCommand 2024-07-16 00:14:14 +07:00
rpc_invalid_address_message.py
rpc_invalidateblock.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
rpc_masternode.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc_misc.py merge bitcoin#23443: Erlay support signaling 2024-10-27 19:38:29 +00:00
rpc_mnauth.py refactor: drop fast_dip3_enforcement=True from functional tests. 2024-09-26 14:17:05 +07:00
rpc_named_arguments.py
rpc_net.py merge bitcoin#28155: improves addnode / m_added_nodes logic 2024-10-26 19:22:32 +00:00
rpc_packages.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
rpc_preciousblock.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
rpc_psbt.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
rpc_quorum.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc_rawtransaction.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
rpc_scantxoutset.py Merge bitcoin/bitcoin#27422: test: add coverage to rpc_scantxoutset.py 2024-10-25 09:59:35 -05:00
rpc_setban.py Merge #6350: backport: trivial 2024 10 23 pr7 2024-10-25 12:58:26 -05:00
rpc_signmessage.py
rpc_signrawtransaction.py
rpc_txoutproof.py Merge bitcoin/bitcoin#23515: test: Return the largest utxo in MiniWallet.get_utxo 2024-10-15 09:25:08 -05:00
rpc_uptime.py
rpc_users.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
rpc_verifychainlock.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc_verifyislock.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc_whitelist.py feat: test composite commands in functional test for whitelist 2024-07-12 00:07:54 +07:00
rpc_wipewallettxes.py chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
test_runner.py perf: re-order functional tests to make slowest one to run faster 2024-10-30 00:11:53 +07:00
test-shell.md Merge #6352: backport: trivial 2024 10 23 pr9 2024-10-25 12:56:23 -05:00
tool_wallet.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_abandonconflict.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_avoidreuse.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_backup.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_balance.py Merge bitcoin/bitcoin#25915: test: Fix wallet_balance intermittent issue 2024-10-24 11:21:49 -05:00
wallet_basic.py Merge bitcoin/bitcoin#28288: test: fix 'unknown named parameter' test in wallet_basic 2024-10-24 11:18:38 -05:00
wallet_change_address.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_coinbase_category.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_create_tx.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_createwallet.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_descriptor.py merge bitcoin#23207: Delete generate* calls from TestNode 2024-10-04 19:01:01 +00:00
wallet_disable.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_dump.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_encryption.py partial Merge #20842: docs: consolidate typo & url fixing 2024-07-26 13:32:54 +07:00
wallet_fallbackfee.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_groups.py Merge bitcoin/bitcoin#26970: test: fix immediate tx relay in wallet_groups.py 2024-10-25 09:08:29 -05:00
wallet_hd.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_import_rescan.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_import_with_label.py
wallet_importdescriptors.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_importmulti.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_importprunedfunds.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_keypool_hd.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_keypool_topup.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_keypool.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_labels.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_listdescriptors.py Merge bitcoin/bitcoin#21500: wallet, rpc: add an option to list private descriptors 2024-10-25 20:51:19 +07:00
wallet_listreceivedby.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_listsinceblock.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_listtransactions.py test: remove redundant sync after generate* calls in Bitcoin tests 2024-10-04 19:01:05 +00:00
wallet_mnemonicbits.py refactor: simplify extra arguments wallet_mnemonicbits.py since usehd=1 is default option 2024-10-11 16:38:53 +07:00
wallet_multiwallet.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_orphanedreward.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00
wallet_reorgsrestore.py Merge bitcoin/bitcoin#29425: test: fix intermittent failure in wallet_reorgrestore.py 2024-10-24 11:16:19 -05:00
wallet_resendwallettransactions.py merge bitcoin#21160: Move tx inventory into net_processing 2024-04-26 20:25:55 +00:00
wallet_send.py fix: uncomment sethdseed to follow-up for #6017 and bitcoin#12560 2024-10-30 00:11:53 +07:00
wallet_startup.py Merge #20813: scripted-diff: Bump copyright headers 2024-04-10 03:19:34 +07:00
wallet_txn_clone.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_txn_doublespend.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_upgradetohd.py merge bitcoin#23300: Implicitly sync after generate*, unless opted out 2024-10-04 19:01:05 +00:00
wallet_upgradewallet.py Merge bitcoin/bitcoin#22461: wallet: Change ScriptPubKeyMan::Upgrade default to True 2024-10-24 16:34:25 +07:00
wallet_watchonly.py merge bitcoin#22788: Use generate* from TestFramework 2024-10-04 19:01:00 +00:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x500=12500 DASH) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the dashd(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a dashd. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a dashd node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: