mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
a37e196dd0
<!-- *** Please remove the following help text before submitting: *** Provide a general summary of your changes in the Title above Pull requests without a rationale and clear improvement may be closed immediately. Please provide clear motivation for your patch and explain how it improves Dash Core user experience or Dash Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Dash Core, if possible. --> ## Issue being fixed or feature implemented <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## What was done? <!--- Describe your changes in detail --> It was requested by service desk to hide old banned masternodes when calling rpc `masternodelist`. The period from which a masternode is considered old banned is more than a `SuperblockCycle`. | Network | SuperblockCycle | | ------------- |:-------------:| | Mainnet | 16616 | | Testnet | 24 | | Devnet | 24 | | Regtest | 10 | The new mode `recent` was added to in order to hide old banned masternodes. Note: If the mode `recent` is used, then the reply mode is `JSON` (can be additionally filtered) ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Breaking Changes <!--- Please describe any breaking changes your code introduces --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
232 B
232 B
Updated RPCs
masternodelistNew moderecentwas added in order to hide banned masternodes for more than oneSuperblockCycle. If the moderecentis used, then the reply mode is JSON (can be additionally filtered)