dash/src
MarcoFalke 90c82aca85
Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
6dd469a3be Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. Remove no-op CClientUIInterface::[signal_name]_disconnect. (practicalswift)

Pull request description:

  Resolves #15698.

  Changes:
  * Remove no-op `CClientUIInterface::[signal_name]_disconnect`.
  * Disconnect `BlockNotifyGenesisWait` and `RPCNotifyBlockChange` properly.

ACKs for commit 6dd469:
  MarcoFalke:
    utACK 6dd469a3bea60d8857ec0be625c2ef8a7716c148

Tree-SHA512: 0b50d658fa72261332bc57ddea379fd08f4bc1de392c10c628e20142d6fd244b606c39fd0665d6bc39324c1aa8c8814ac942b4659106279e33b90206aaf37411
2021-10-25 12:22:06 -04:00
..
bench Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
bls refac: use make_unique and constexpr (#4493) 2021-10-11 00:41:53 +03:00
coinjoin refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
compat Partial Merge #13665: [build] Add risc-v support to gitian 2021-09-21 17:27:09 -04:00
config
consensus refactor: more LLMQ params related refactoring (#4517) 2021-10-15 13:28:19 +03:00
crc32c Merge #20603: build: Update crc32c subtree 2021-09-24 13:26:41 -04:00
crypto Merge #19931: Change CSipHasher's count variable to uint8_t 2021-09-24 13:26:37 -04:00
evo refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
governance refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
index merge bitcoin#15948: rename chainActive 2021-10-22 08:15:22 +05:30
interfaces merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
leveldb partial merge #17398: Update leveldb to 1.22+ (#4230) 2021-07-15 15:42:55 -05:00
llmq refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
logging Fix more spelling errors 2021-07-19 12:52:03 -05:00
masternode refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
node merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
policy merge bitcoin#15948: rename chainActive 2021-10-22 08:15:22 +05:30
primitives merge bitcoin#14906: Make explicit CMutableTransaction -> CTransaction conversion 2021-10-12 08:58:08 +05:30
qt Merge #15655: Resolve the checkpoints <-> validation circular dependency 2021-10-25 12:22:06 -04:00
rpc Merge #15655: Resolve the checkpoints <-> validation circular dependency 2021-10-25 12:22:06 -04:00
script Merge pull request #4449 from PastaPastaPasta/backport-trivial-pr22 2021-09-25 00:43:30 +03:00
secp256k1 Partial merge #22448: Update libsecp256k1 subtree to latest upstream 2021-08-11 00:05:23 +03:00
support Merge bitcoin#23181: refactor: remove references to deprecated values under std::allocator (#4534) 2021-10-23 19:26:55 +03:00
test Merge #15352: tests: Reduce noise level in test_bitcoin output 2021-10-25 12:20:19 -04:00
univalue Merge #20424: build: Update univalue subtree 2021-07-17 12:09:42 -05:00
util Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
wallet Merge #15352: tests: Reduce noise level in test_bitcoin output 2021-10-25 12:20:19 -04:00
zmq Merge bitcoin#14726: Use RPCHelpMan for all RPCs (#4492) 2021-10-12 00:55:23 +03:00
.clang-format Merge #19454: tools: .clang-format compat with clang versions < 9 2021-07-15 19:30:07 -05:00
addrdb.cpp Merge #21222: log: Clarify log message when file does not exist 2021-09-18 21:41:47 -04:00
addrdb.h Merge #14605: Return of the Banman 2021-07-17 22:32:12 -05:00
addressindex.h
addrman.cpp Merge #13258: uint256: Remove unnecessary crypto/common.h dependency 2021-10-21 17:41:33 +05:30
addrman.h Merge #15109: refactor: Use C++11 default member initializers 2021-08-10 22:20:30 -03:00
amount.h Merge #14244: amount: Move CAmount CENT to unit test header 2021-07-01 16:57:02 -05:00
arith_uint256.cpp Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits() 2021-07-01 17:20:18 -05:00
arith_uint256.h Merge #14838: Use const in COutPoint class 2021-07-08 11:57:10 -05:00
attributes.h merge bitcoin#20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17) 2021-06-27 12:03:14 +05:30
banman.cpp Merge pull request #4435 from PastaPastaPasta/backport-trivial-pr20 2021-09-24 23:10:10 +03:00
banman.h Merge #14929: net: Allow connections from misbehavior banned peers 2021-07-19 18:57:23 -05:00
base58.cpp Merge #14585: refactor: remove usage of locale dependent std::isspace 2021-09-09 10:53:54 -07:00
base58.h merge bitcoin#20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17) 2021-06-27 12:03:14 +05:30
batchedlogger.cpp Merge #15266: memory: Construct globals on first use 2021-09-16 07:41:45 +05:30
batchedlogger.h Merge #12954: util: Refactor logging code into a global object 2021-05-25 14:09:35 +03:00
bech32.cpp Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
bech32.h Merge #16792: Assert that the HRP is lowercase in Bech32::Encode 2021-07-12 20:52:56 -05:00
bip39_english.h
bip39.cpp
bip39.h
blockencodings.cpp merge bitcoin#14074: Use std::unordered_set instead of set in blockfilter interface 2021-06-27 12:03:15 +05:30
blockencodings.h merge #18635: Replace -Wthread-safety-analysis with -Wthread-safety 2021-06-10 14:35:05 +05:30
blockfilter.cpp Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
blockfilter.h Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
bloom.cpp refactor: llmq/quorums_*[cpp/h] --> llmq/*.[cpp/h] 2021-10-06 09:04:45 +05:30
bloom.h Merge #19968: doc: clarify CRollingBloomFilter size estimate 2021-07-15 19:37:59 -05:00
cachemap.h refactor: replace instances of typedef with using in dash code (#4488) 2021-10-06 00:26:29 +03:00
cachemultimap.h refactor: replace instances of typedef with using in dash code (#4488) 2021-10-06 00:26:29 +03:00
chain.cpp
chain.h Merge #14556: qt: fix confirmed transaction labeled "open" (#13299) 2021-10-13 23:44:02 -05:00
chainparams.cpp refactor: more LLMQ params related refactoring (#4517) 2021-10-15 13:28:19 +03:00
chainparams.h refactor: more LLMQ params related refactoring (#4517) 2021-10-15 13:28:19 +03:00
chainparamsbase.cpp merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
chainparamsbase.h backport bitcoin#13190: Have gArgs handle printing help 2021-03-19 18:00:24 +03:00
chainparamsseeds.h contrib|src: Update hard coded seeds (#4152) 2021-05-13 12:31:45 +03:00
checkqueue.h Merge #17971: refactor: Remove redundant conditional 2021-09-18 17:15:44 -04:00
clientversion.cpp Adjust version formatting and add formatted version to rpc (#3908) 2021-01-11 20:34:42 +01:00
clientversion.h
coins.cpp merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
coins.h merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
compat.h Merge #14715: Drop defunct prevector compat handling 2021-10-11 17:17:07 -05:00
compressor.cpp Merge #12752: Move compressor utility functions out of class 2021-04-18 17:10:05 -04:00
compressor.h Merge #17957: Convert compression.h to new serialization framework 2021-04-18 17:10:25 -04:00
core_io.h Merge bitcoin#13399: rpc: Add submitheader (#4326) 2021-08-10 22:37:50 +03:00
core_memusage.h
core_read.cpp Merge bitcoin#13399: rpc: Add submitheader (#4326) 2021-08-10 22:37:50 +03:00
core_write.cpp refactor: llmq/quorums_*[cpp/h] --> llmq/*.[cpp/h] 2021-10-06 09:04:45 +05:30
ctpl_stl.h Fix data races in bls_worker and use ctpl_stl queue. (#4240) 2021-07-11 22:25:27 -05:00
cuckoocache.h Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
dash-tx-res.rc
dash-tx.cpp refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
dashd-res.rc
dashd.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
dbwrapper.cpp Merge #13954: Warn (don't fail!) on spelling errors. Fix typos reported by codespell. 2021-07-19 12:51:24 -05:00
dbwrapper.h Cxx17 refac ci trivial (#4507) 2021-10-12 00:55:49 +03:00
dsnotificationinterface.cpp merge bitcoin#15976: move methods under CChainState 2021-10-22 08:15:38 +05:30
dsnotificationinterface.h instantsend: Use NotifyEntryRemoved signal instead of calling CInstantSendManager::TransactionRemovedFromMempool from CTxMemPool::removeUnchecked directly (#4160) 2021-05-19 01:02:31 +02:00
dummywallet.cpp Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
flat-database.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
flatfile.cpp bitcoin#15118: Refactor block file logic 2021-08-12 12:32:29 +05:30
flatfile.h bitcoin#15118: Refactor block file logic 2021-08-12 12:32:29 +05:30
fs.cpp Merge #15782: Avoid redefine warning 2021-09-28 14:46:47 -04:00
fs.h Merge #14768: revert removal of fstream.hpp header in fs.h 2021-08-10 20:24:28 -04:00
hash.cpp merge bitcoin#14074: Use std::unordered_set instead of set in blockfilter interface 2021-06-27 12:03:15 +05:30
hash.h Merge #13258: uint256: Remove unnecessary crypto/common.h dependency 2021-10-21 17:41:33 +05:30
hdchain.cpp Merge #12924: Fix hdmaster-key / seed-key confusion (scripted diff) 2021-06-28 02:00:48 +03:00
hdchain.h Hold locks in CHDChain::swap() 2021-07-13 19:43:31 +03:00
httprpc.cpp bitcoin#14168: Remove ENABLE_WALLET from libbitcoin_server.a 2021-08-11 09:48:41 +05:30
httprpc.h Merge #13938: refactoring: Cleanup StartRest() 2021-07-19 17:11:14 -05:00
httpserver.cpp Use make_unique instead of using new (#4502) 2021-10-11 20:11:42 +03:00
httpserver.h Merge #14214: convert C-style (void) parameter lists to C++ style () 2021-07-12 11:50:33 -04:00
indirectmap.h
init.cpp Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. 2021-10-25 12:22:06 -04:00
init.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
keepass.cpp fix misc. spelling errors 2021-07-19 12:51:30 -05:00
keepass.h Update copyright (#4115) 2021-04-20 22:33:02 +03:00
key_io.cpp refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
key_io.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
key.cpp Merge #19228: Update libsecp256k1 subtree 2021-08-11 00:05:22 +03:00
key.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
keystore.cpp merge bitcoin#14555: Move util files to directory 2021-06-27 12:03:13 +05:30
keystore.h Merge #13627: Free keystore.h from file scope level type aliases 2020-12-18 12:55:45 -06:00
limitedmap.h
logging.cpp merge bitcoin#18881: Prevent UB in DeleteLock() function 2021-10-12 19:41:02 -04:00
logging.h Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
Makefile.am Merge #15655: Resolve the checkpoints <-> validation circular dependency 2021-10-25 12:22:06 -04:00
Makefile.bench.include Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
Makefile.crc32c.include Merge #20603: build: Update crc32c subtree 2021-09-24 13:26:41 -04:00
Makefile.leveldb.include partial merge #17398: Update leveldb to 1.22+ (#4230) 2021-07-15 15:42:55 -05:00
Makefile.qt.include Cxx17 refac ci build (#4508) 2021-10-12 00:56:11 +03:00
Makefile.qttest.include Merge #11625: Add BitcoinApplication & RPCConsole tests 2021-09-18 17:13:54 -04:00
Makefile.test.include merge bitcoin#16945: introduce CChainState::GetCoinsCacheSizeState 2021-10-22 08:15:38 +05:30
memusage.h
merkleblock.cpp Merge #15139: util: Remove [U](BEGIN|END) macros 2021-08-24 19:14:49 -04:00
merkleblock.h partial merge #18317: Serialization improvements step 6 (all except wallet/gui) 2021-05-28 11:39:24 +03:00
messagesigner.cpp merge bitcoin#14555: Move util files to directory 2021-06-27 12:03:13 +05:30
messagesigner.h Fix more spelling errors 2021-07-19 12:52:03 -05:00
miner.cpp merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
miner.h Merge #19283: refactor: Remove unused BlockAssembler::pblock member var 2021-07-15 19:30:07 -05:00
net_permissions.cpp Merge #16248: Make whitebind/whitelist permissions more flexible 2021-07-19 19:00:04 -05:00
net_permissions.h Merge #16248: Make whitebind/whitelist permissions more flexible 2021-07-19 19:00:04 -05:00
net_processing.cpp merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
net_processing.h merge bitcoin#18877: Serve cfcheckpt requests 2021-09-19 10:01:43 +05:30
net.cpp merge bitcoin#16092: Don't use global (external) symbols for symbols that are used in only one translation unit 2021-10-22 08:15:38 +05:30
net.h Add some thread annotations (#4464) 2021-09-29 00:23:34 +03:00
netaddress.cpp Merge #20140: Restore compatibility with old CSubNet serialization 2021-09-24 13:26:39 -04:00
netaddress.h Merge #20140: Restore compatibility with old CSubNet serialization 2021-09-24 13:26:39 -04:00
netbase.cpp Merge #14331: doxygen: Fix member comments 2021-08-18 13:56:38 -05:00
netbase.h
netfulfilledman.cpp Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
netfulfilledman.h Other Dash-specific serializations 2021-05-28 12:31:13 +03:00
netmessagemaker.h
noui.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
noui.h merge bitcoin#16277: suppress output in test_bitcoin for expected errors 2021-10-20 12:29:45 -04:00
pow.cpp
pow.h
prevector.h Merge #14715: Drop defunct prevector compat handling 2021-10-11 17:17:07 -05:00
protocol.cpp instantsend: deterministic lock using the same msg hash as islock (#4381) 2021-10-05 20:42:34 +03:00
protocol.h instantsend: deterministic lock using the same msg hash as islock (#4381) 2021-10-05 20:42:34 +03:00
psbt.cpp Merge #15408: Remove unused TransactionError constants 2021-09-30 16:18:49 -07:00
psbt.h Merge #15408: Remove unused TransactionError constants 2021-09-30 16:18:49 -07:00
pubkey.cpp Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
pubkey.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
random.cpp Merge #17191: random: remove call to RAND_screen() (Windows only) 2021-09-21 14:42:21 -04:00
random.h Merge #15250: Use RdSeed when available, and reduce RdRand load 2021-09-16 13:34:59 +03:00
rest.cpp merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
reverse_iterator.h
saltedhasher.cpp Update copyright (#4115) 2021-04-20 22:33:02 +03:00
saltedhasher.h merge bitcoin#14074: Use std::unordered_set instead of set in blockfilter interface 2021-06-27 12:03:15 +05:30
scheduler.cpp partial Merge #18234: refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler 2021-09-28 19:42:22 -04:00
scheduler.h partial Merge #19090: refactor: Misc scheduler cleanups 2021-09-28 19:42:27 -04:00
serialize.h masternode-meta.*: add thread annotations, atomic usage, remove unneeded locks (#4466) 2021-10-01 00:00:52 +03:00
shutdown.cpp Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
shutdown.h Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
span.h Partial #19326: Simplify hash.h interface using Spans 2021-05-20 10:15:17 +05:30
spentindex.h Other Dash-specific serializations 2021-05-28 12:31:13 +03:00
spork.cpp refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
spork.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
stacktraces.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
stacktraces.h Update copyright (#4115) 2021-04-20 22:33:02 +03:00
statsd_client.cpp merge bitcoin#14555: Move util files to directory 2021-06-27 12:03:13 +05:30
statsd_client.h trivial: misc. trivial refactoring (#4104) 2021-04-15 13:58:04 -04:00
streams.h Merge #14357: streams: Fix broken streams_vector_reader test. Remove unused seek(size_t). 2021-09-07 12:26:47 -04:00
sync.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
sync.h merge bitcoin#19340: Preserve the LockData initial state if "potential deadlock detected" exception thrown 2021-10-12 19:48:19 -04:00
threadinterrupt.cpp merge #11640: Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection 2021-06-06 16:22:17 +05:30
threadinterrupt.h merge #11599: Small locking rename 2021-06-06 16:22:17 +05:30
threadsafety.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
timedata.cpp Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
timedata.h
tinyformat.h Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
torcontrol.cpp Merge #16186: doc/lint: Fix spelling errors identified by codespell 1.15.0 2021-10-05 20:34:00 +03:00
torcontrol.h
txdb.cpp merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
txdb.h merge bitcoin#16945: introduce CChainState::GetCoinsCacheSizeState 2021-10-22 08:15:38 +05:30
txmempool.cpp refactor: llmq/quorums_*[cpp/h] --> llmq/*.[cpp/h] 2021-10-06 09:04:45 +05:30
txmempool.h merge bitcoin#16443: have CCoins* data managed under CChainState 2021-10-22 08:15:38 +05:30
ui_interface.cpp Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. 2021-10-25 12:22:06 -04:00
ui_interface.h Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. 2021-10-25 12:22:06 -04:00
uint256.cpp Merge #14599: Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. Remove the use of locale dependent boost::is_space(...) 2021-09-09 11:23:24 -07:00
uint256.h Merge #13258: uint256: Remove unnecessary crypto/common.h dependency 2021-10-21 17:41:33 +05:30
undo.h Merge #18433: serialization: prevent int overflow for big Coin::nHeight 2021-07-13 21:19:48 -05:00
unordered_lru_cache.h Fix error int64_t was not declared (#4419) 2021-09-13 12:56:35 -04:00
validation.cpp Merge #15655: Resolve the checkpoints <-> validation circular dependency 2021-10-25 12:22:06 -04:00
validation.h merge bitcoin#15855: Add missing LockAnnotation for cs_main (#4530) 2021-10-25 16:14:34 +03:00
validationinterface.cpp Backports v0.18: PR 13743: refactor: Replace boost::bind with std::bind (#4343) 2021-08-17 23:31:09 +03:00
validationinterface.h Merge #13083: Add compile time checking for cs_main runtime locking assertions 2021-07-07 16:30:58 -04:00
version.h instantsend: deterministic lock using the same msg hash as islock (#4381) 2021-10-05 20:42:34 +03:00
versionbits.cpp merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
versionbits.h merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
versionbitsinfo.cpp merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
versionbitsinfo.h merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
walletinitinterface.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
warnings.cpp Merge #19220: refactor: Replace RecursiveMutex with Mutex in warnings.cpp 2021-09-18 21:46:24 -04:00
warnings.h