mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
02c6ecb02f
418d3230f8 Resolve the checkpoints <-> validation CD. (251)
Pull request description:
This pull request attempts to resolve the `checkpoints -> validation -> checkpoints` circular dependency.
The circular dependency is resolved by moving the `CheckPoints::GetLastCheckpoint(const CCheckpointData& data)` function to `validation.cpp` where it used exclusively by the private function `ContextualCheckBlockHeader(const CBlockHeader& block, CValidationState& state, const CChainParams& params, const CBlockIndex* pindexPrev, int64_t nAdjustedTime)`.
ACKs for commit 418d32:
promag:
utACK 418d323, only `GetLastCheckpoint` usage is in `validation.cpp` and so makes sense to move it there.
practicalswift:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
MarcoFalke:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
sipa:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
Tree-SHA512: 03c3556bc192e65f5e3fa76fd545d4ee7d63d3fb06b132f7a1fa6131aa21ddd2e5b2d19e2222dfe524f422daaca30efde219bed188db8c74ff4b088876b5bc16
|
||
|---|---|---|
| .. | ||
| blockchain.cpp | ||
| blockchain.h | ||
| client.cpp | ||
| client.h | ||
| coinjoin.cpp | ||
| governance.cpp | ||
| masternode.cpp | ||
| mining.cpp | ||
| mining.h | ||
| misc.cpp | ||
| net.cpp | ||
| protocol.cpp | ||
| protocol.h | ||
| rawtransaction.cpp | ||
| rawtransaction.h | ||
| register.h | ||
| rpcevo.cpp | ||
| rpcquorums.cpp | ||
| server.cpp | ||
| server.h | ||
| util.cpp | ||
| util.h | ||