mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
830fe11153
fae9e84cbb doc: Add GitHub pr template (MarcoFalke) Pull request description: Bitcoin Core has a very thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. Authors should provide clear motivation for patches and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly. Tree-SHA512: 83b379d75934089f13ba173e6ec847845f954f10f83e406ef9722836aa093170c612b4214f22cd5939d59f66a50f5d0e52aa0059423e8e7261bb176f1c546a08
19 lines
959 B
Markdown
19 lines
959 B
Markdown
Pull requests without a rationale and clear improvement may be closed
|
|
immediately.
|
|
|
|
Please provide clear motivation for your patch and explain how it improves
|
|
Dash Core user experience or Dash Core developer experience
|
|
significantly.
|
|
|
|
* Any test improvements or new tests that improve coverage are always welcome.
|
|
* All other changes should have accompanying unit tests (see `src/test/`) or
|
|
functional tests (see `test/`). Contributors should note which tests cover
|
|
modified code. If no tests exist for a region of modified code, new tests
|
|
should accompany the change.
|
|
* Bug fixes are most welcome when they come with steps to reproduce or an
|
|
explanation of the potential issue as well as reasoning for the way the bug
|
|
was fixed.
|
|
* Features are welcome, but might be rejected due to design or scope issues.
|
|
If a feature is based on a lot of dependencies, contributors should first
|
|
consider building the system outside of Dash Core, if possible.
|