dash/src/privatesend
UdjinM6 c82e433913
Streamline, refactor and unify PS checks for mixing entries and final txes (#3246)
* Move PS mixing entry verification on masternodes into `AddEntry()`

Also streamline logic a bit and drop unused/excessive parts.

* Unify PS checks among masternodes and clients

* No need to re-check outputs over and over again

* No need to count, fail early if any output is missing

* No need to look any further once we found the input we expected

A tx with duplicate inputs would be considered invalid anyway and we also know there are no duplicates because we just verified the final tx above.

Also drop an unused variable.

* Unify LogPrint-s

* Drop human-readable strings for unused PoolMessage-s

* Apply suggestions from code review

Co-Authored-By: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Re-introduce zero-fee checks

* fix log

* Move all txin/txout verification logic shared by CPrivateSendClientSession::SignFinalTransaction() and CPrivateSendServer::AddEntry() into CPrivateSendBaseSession::IsValidInOuts()

* fix nit

* Add missing return

* Use CCoinsViewMemPool instead of doing it manually

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
Co-authored-by: Alexander Block <ablock84@gmail.com>
2020-01-01 17:12:25 +03:00
..
privatesend-client.cpp Streamline, refactor and unify PS checks for mixing entries and final txes (#3246) 2020-01-01 17:12:25 +03:00
privatesend-client.h Introduce getprivatesendinfo and deprecate getpoolinfo (#3140) 2019-10-09 19:48:53 +03:00
privatesend-server.cpp Streamline, refactor and unify PS checks for mixing entries and final txes (#3246) 2020-01-01 17:12:25 +03:00
privatesend-server.h Streamline, refactor and unify PS checks for mixing entries and final txes (#3246) 2020-01-01 17:12:25 +03:00
privatesend-util.cpp Disable move ctor/operator for CKeyHolder (#3162) 2019-10-19 13:40:12 +03:00
privatesend-util.h Disable move ctor/operator for CKeyHolder (#3162) 2019-10-19 13:40:12 +03:00
privatesend.cpp Streamline, refactor and unify PS checks for mixing entries and final txes (#3246) 2020-01-01 17:12:25 +03:00
privatesend.h Streamline, refactor and unify PS checks for mixing entries and final txes (#3246) 2020-01-01 17:12:25 +03:00