PastaPastaPasta d40ac79d4d feat: rpc submitchainlock short circuit if possible and always return… (#5806) ... … best height ## Issue being fixed or feature implemented Platform wants to know the height of the bestchainlock when they call submitchainlock; sooo we change the API of submitchainlock to also return the height ## What was done? Adjust API and tests ## How Has This Been Tested? New tests added for this behavior ## Breaking Changes Not really any; I **guess** that return value could be considered breaking change; but going from nothing -> something feels unlikely to break anything although it in theory could. ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> Co-authored-by: Konstantin Akimov <knstqq@gmail.com>		2024-02-01 10:14:59 -06:00
..
bench	partial Merge #20004: test: Add signet witness commitment section parse tests	2024-01-31 11:32:23 -06:00
bls
coinjoin	Merge #17785: p2p: Unify Send and Receive protocol versions	2024-01-27 22:55:28 -06:00
compat
config
consensus	fix: revive IsQuorumTypeEnabled logic dropped in 5790 (#5841)	2024-01-27 22:56:55 -06:00
crc32c
crypto	Merge #19403: build: improve __builtin_clz* detection	2024-01-16 15:05:08 -06:00
dashbls
evo	partial Merge #20004: test: Add signet witness commitment section parse tests	2024-01-31 11:32:23 -06:00
governance	Merge #17785: p2p: Unify Send and Receive protocol versions	2024-01-27 22:55:28 -06:00
gsl
immer
index	Merge #19233: Make SetMiscWarning() accept bilingual_str argument	2024-01-16 15:05:05 -06:00
interfaces	Merge bitcoin-core/gui#35: Parse params directly instead of through node (partial revert #10244)	2024-01-31 11:32:24 -06:00
leveldb
llmq	fix: revive IsQuorumTypeEnabled logic dropped in 5790 (#5841)	2024-01-27 22:56:55 -06:00
logging
masternode	Merge #17785: p2p: Unify Send and Receive protocol versions	2024-01-27 22:55:28 -06:00
node	Merge bitcoin-core/gui#35: Parse params directly instead of through node (partial revert #10244)	2024-01-31 11:32:24 -06:00
policy	Merge #20787: Use C++17 std::array deduction for OUTPUT_TYPES, ALL_FEE_ESTIMATE_HORIZONS	2024-01-16 07:57:34 -06:00
primitives
qt	Merge bitcoin-core/gui#35: Parse params directly instead of through node (partial revert #10244)	2024-01-31 11:32:24 -06:00
rpc	feat: rpc submitchainlock short circuit if possible and always return… (#5806)	2024-02-01 10:14:59 -06:00
script	Merge #20006: Fix misleading error message: Clean stack rule	2024-01-22 19:47:12 -06:00
secp256k1
support	Merge #15704: Move Win32 defines to configure.ac to ensure they are globally defined	2024-01-10 19:22:58 -06:00
test	partial Merge #20245: test: Run script_assets_test even if built --with-libs=no	2024-02-01 09:22:05 -06:00
univalue
util	Merge #15382: util: add RunCommandParseJSON	2024-02-01 09:22:03 -06:00
wallet	fix: don't make keypool refill spam progress bars (#5851)	2024-01-31 11:41:57 -06:00
zmq
.clang-format
addrdb.cpp
addrdb.h
addressindex.cpp
addressindex.h
addrman.cpp	Merge bitcoin/bitcoin#25303: refactor: Remove redundant addrman time checks	2024-01-19 11:02:23 -06:00
addrman.h
amount.h
arith_uint256.cpp
arith_uint256.h	Merge bitcoin/bitcoin#24854: Remove not needed ArithToUint256 roundtrips in tests	2024-01-13 19:32:31 -06:00
attributes.h
banman.cpp	Merge bitcoin/bitcoin#24168: Fix some race conditions in BanMan::DumpBanlist()	2024-01-13 19:32:30 -06:00
banman.h
base58.cpp	Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}	2024-01-10 19:22:58 -06:00
base58.h	Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}	2024-01-10 19:22:58 -06:00
batchedlogger.cpp
batchedlogger.h
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp
bip39.h
bitcoin-cli.cpp	Merge #19453: refactor: reduce DefaultRequestHandler memory allocations	2024-01-23 22:14:14 -06:00
bitcoin-tx.cpp
bitcoin-wallet.cpp
bitcoind.cpp	Merge #19331: build: Do not include server symbols in wallet	2024-01-10 12:06:05 -06:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp	refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733)	2024-01-11 21:43:01 -06:00
bloom.h
cachemap.h
cachemultimap.h
chain.cpp
chain.h
chainparams.cpp	partial Merge #20004: test: Add signet witness commitment section parse tests	2024-01-31 11:32:23 -06:00
chainparams.h	partial Merge #20004: test: Add signet witness commitment section parse tests	2024-01-31 11:32:23 -06:00
chainparamsbase.cpp
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp	feat: Set client version for non-release binaries and version in guix based on git tags (#5653)	2024-01-11 21:43:42 -06:00
clientversion.h
coins.cpp
coins.h
compat.h	Merge #15704: Move Win32 defines to configure.ac to ensure they are globally defined	2024-01-10 19:22:58 -06:00
compressor.cpp
compressor.h
context.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp	refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733)	2024-01-11 21:43:01 -06:00
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dsnotificationinterface.cpp	refactor: rename CJClientManager	2024-01-10 12:06:01 -06:00
dsnotificationinterface.h
dummywallet.cpp	refactor: rename CJClientManager	2024-01-10 12:06:01 -06:00
flat-database.h
flatfile.cpp
flatfile.h
fs.cpp
fs.h
hash.cpp
hash.h
hdchain.cpp
hdchain.h	Merge bitcoin/bitcoin#25017: validation: make CScriptCheck and prevector swap members noexcept	2024-01-13 19:32:32 -06:00
httprpc.cpp
httprpc.h
httpserver.cpp	Merge bitcoin/bitcoin#23607: rpc: Pass const char* to evhttp_connection_get_peer for new libevent	2024-01-13 19:32:29 -06:00
httpserver.h
i2p.cpp
i2p.h
indirectmap.h
init.cpp	partial Merge #20004: test: Add signet witness commitment section parse tests	2024-01-31 11:32:23 -06:00
init.h
key_io.cpp
key_io.h
key.cpp
key.h
limitedmap.h
logging.cpp
logging.h
Makefile.am	refactor: split llmq/utils to Quorum Calculation and llmq/options (#5790)	2024-01-17 19:56:41 -06:00
Makefile.bench.include
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include	partial Merge #18027: "PSBT Operations" dialog	2024-01-31 11:32:22 -06:00
Makefile.qttest.include
Makefile.test_fuzz.include
Makefile.test_util.include
Makefile.test.include	Merge #15382: util: add RunCommandParseJSON	2024-02-01 09:22:03 -06:00
Makefile.univalue.include
mapport.cpp
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
messagesigner.cpp
messagesigner.h
miner.cpp	Merge bitcoin/bitcoin#24934: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs	2024-01-19 11:02:22 -06:00
miner.h
net_permissions.cpp
net_permissions.h
net_processing.cpp	Merge #19109: Only allow getdata of recently announced invs	2024-01-27 22:55:30 -06:00
net_processing.h	Merge #19914: refactor: Do not pass chain params to CheckForStaleTipAndEvictPeers twice	2024-01-22 19:47:12 -06:00
net_types.h	refactor: new helpers in net_processing for external handlers	2024-01-10 15:12:05 -06:00
net.cpp	Merge #19731: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo	2024-01-28 22:20:47 +07:00
net.h	Merge #20105: [net] Remove CombinerAll	2024-01-31 11:32:23 -06:00
netaddress.cpp
netaddress.h	Merge #20119: BIP155 follow-ups	2024-01-22 19:47:13 -06:00
netbase.cpp
netbase.h
netfulfilledman.cpp
netfulfilledman.h
netmessagemaker.h
noui.cpp	Merge #19331: build: Do not include server symbols in wallet	2024-01-10 12:06:05 -06:00
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h	Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v	2024-01-14 11:05:36 -06:00
protocol.cpp	Merge #19818: p2p: change CInv::type from int to uint32_t, fix UBSan warning	2024-01-22 19:44:37 -06:00
protocol.h	Merge #19610: p2p: refactor AlreadyHave(), CInv::type, INV/TX processing	2024-01-27 22:55:26 -06:00
psbt.cpp	partial Merge #18027: "PSBT Operations" dialog	2024-01-31 11:32:22 -06:00
psbt.h	partial Merge #18027: "PSBT Operations" dialog	2024-01-31 11:32:22 -06:00
pubkey.cpp
pubkey.h
random.cpp
random.h
randomenv.cpp
randomenv.h
rest.cpp
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp	Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient	2024-01-13 23:09:41 -06:00
scheduler.h	Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient	2024-01-13 23:09:41 -06:00
serialize.h
shutdown.cpp	Merge #19233: Make SetMiscWarning() accept bilingual_str argument	2024-01-16 15:05:05 -06:00
shutdown.h
source_location.h
span.h
spentindex.h
spork.cpp	Merge #17785: p2p: Unify Send and Receive protocol versions	2024-01-27 22:55:28 -06:00
spork.h	refactor: spork no more depends on net_processing	2024-01-10 15:12:06 -06:00
stacktraces.cpp
stacktraces.h
statsd_client.cpp
statsd_client.h
streams.h
sync.cpp
sync.h	Merge #20495: sync: Use decltype(auto) return type for WITH_LOCK	2024-01-16 07:57:35 -06:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp	Merge #19233: Make SetMiscWarning() accept bilingual_str argument	2024-01-16 15:05:05 -06:00
timedata.h
timestampindex.h
tinyformat.h
torcontrol.cpp
torcontrol.h
txdb.cpp	Merge #19331: build: Do not include server symbols in wallet	2024-01-10 12:06:05 -06:00
txdb.h
txmempool.cpp	Merge #20944: rpc: Return total fee in getmempoolinfo	2024-01-16 09:29:49 -06:00
txmempool.h	Merge #19879: [p2p] miscellaneous wtxid followups	2024-01-27 22:55:28 -06:00
uint256.cpp
uint256.h
undo.h
unordered_lru_cache.h
validation.cpp	Merge #19879: [p2p] miscellaneous wtxid followups	2024-01-27 22:55:28 -06:00
validation.h	Merge bitcoin/bitcoin#25017: validation: make CScriptCheck and prevector swap members noexcept	2024-01-13 19:32:32 -06:00
validationinterface.cpp	Merge bitcoin/bitcoin#25040: refactor: Pass lifetimebound reference to SingleThreadedSchedulerClient	2024-01-13 23:09:41 -06:00
validationinterface.h	Merge #18982: wallet: Minimal fix to restore conflicted transaction notifications	2024-01-10 12:07:53 -06:00
version.h
versionbits.cpp
versionbits.h
walletinitinterface.h	refactor: rename CJClientManager	2024-01-10 12:06:01 -06:00
warnings.cpp	Merge #19233: Make SetMiscWarning() accept bilingual_str argument	2024-01-16 15:05:05 -06:00
warnings.h	Merge #19233: Make SetMiscWarning() accept bilingual_str argument	2024-01-16 15:05:05 -06:00