dash/src/wallet
Alessandro Rezzi 2238e03bae
fix: don't make keypool refill spam progress bars (#5851)
## Issue being fixed or feature implemented
 
Trivial bug: `keypoolrefill` internally updates the status of the
progress bar each second.
```
m_storage.UpdateProgress(strMsg, static_cast<int>(dProgress));
```
However it can happen that one second is not enough time to make
significant progress and
 `static_cast<int>(dProgress) = 0`. 
Calling the function with `0` as progress opens a new progress bar and
this led to problems like #5730



## What was done?

  trivially make sure to update the progress only if the parameter is >0


## How Has This Been Tested?

  rpc does not spam anymore


## Checklist:
_Go over all the following points, and put an `x` in all the boxes that
apply._
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2024-01-31 11:41:57 -06:00
..
test Merge #19493: wallet: Fix clang build in Mac 2024-01-10 19:22:58 -06:00
bdb.cpp merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
bdb.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
coincontrol.cpp Merge #17829: scripted-diff: Bump copyright of files changed in 2019 2023-12-06 11:40:14 -06:00
coincontrol.h Merge #15906: [wallet] Move min_depth and max_depth to coin control 2023-04-04 12:45:27 -05:00
coinselection.cpp refactor: rename namespace CCoinJoin to CoinJoin 2024-01-10 12:05:59 -06:00
coinselection.h refactor: replace llmq::quorumInstantSendManager->IsLocked() to new chain's interface 2023-12-17 12:42:45 -06:00
context.cpp refactor: introduce and use CoinJoin::Loader interface 2024-01-10 12:06:02 -06:00
context.h chore: add TODO accordingly init order issue for g_wallet_init_interface and WalletContext 2024-01-10 12:06:04 -06:00
crypter.cpp Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
crypter.h Merge #17829: scripted-diff: Bump copyright of files changed in 2019 2023-12-06 11:40:14 -06:00
db.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
db.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
fees.cpp
fees.h
init.cpp Merge #19331: build: Do not include server symbols in wallet 2024-01-10 12:06:05 -06:00
interfaces.cpp partial Merge #18027: "PSBT Operations" dialog 2024-01-31 11:32:22 -06:00
ismine.h Merge #17829: scripted-diff: Bump copyright of files changed in 2019 2023-12-06 11:40:14 -06:00
load.cpp refactor: working with raw pointer of coinjoin_loader instead reference to unique_ptr 2024-01-10 12:06:04 -06:00
load.h refactor: working with raw pointer of coinjoin_loader instead reference to unique_ptr 2024-01-10 12:06:04 -06:00
rpcdump.cpp Merge #20211: Use -Wswitch for TxoutType where possible 2024-01-16 09:29:50 -06:00
rpcwallet.cpp Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins 2024-01-22 19:44:36 -06:00
rpcwallet.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
salvage.cpp refactor: introduce and use CoinJoin::Loader interface 2024-01-10 12:06:02 -06:00
salvage.h
scriptpubkeyman.cpp fix: don't make keypool refill spam progress bars (#5851) 2024-01-31 11:41:57 -06:00
scriptpubkeyman.h partial Merge #18027: "PSBT Operations" dialog 2024-01-31 11:32:22 -06:00
sqlite.cpp fix: 5072 follow-ups (#5197) 2023-02-12 20:12:53 -06:00
sqlite.h (Partial) Merge #20125: rpc, wallet: Expose database format in getwalletinfo 2023-07-26 15:40:19 +05:30
wallet.cpp partial Merge #18027: "PSBT Operations" dialog 2024-01-31 11:32:22 -06:00
wallet.h partial Merge #18027: "PSBT Operations" dialog 2024-01-31 11:32:22 -06:00
walletdb.cpp refactor: untie governance/object and wallet implementation 2023-12-21 23:04:40 -06:00
walletdb.h refactor: untie governance/object and wallet implementation 2023-12-21 23:04:40 -06:00
wallettool.cpp refactor: introduce and use CoinJoin::Loader interface 2024-01-10 12:06:02 -06:00
wallettool.h Merge #17829: scripted-diff: Bump copyright of files changed in 2019 2023-12-06 11:40:14 -06:00
walletutil.cpp merge bitcoin#20275: List all wallets in non-SQLite and non-BDB builds 2023-02-07 10:53:33 -06:00
walletutil.h Merge #17829: scripted-diff: Bump copyright of files changed in 2019 2023-12-06 11:40:14 -06:00