e0ba1fc72d
fa48405ef84985e5a9d38ec38e90d16596ea45b5 Warn on unknown rw_settings (MarcoFalke) Pull request description: Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded. Something similar is already done for the command line and config file. See: * test: Add test for unknown args #16234 (commit fa7dd88b71a1c6641bd450fae29a4a31849b1afd) ACKs for top commit: ryanofsky: Code review ACK fa48405ef84985e5a9d38ec38e90d16596ea45b5. Looks good and I could see this being helpful for debugging. Thanks for taking suggestions Tree-SHA512: cec7d88adf84fa0a842f56b26245157736eb50df433db951e622ea07fd145b899822b24cdab1d8b36c066415ce4f0ef09b493fa8a8d691532822a59c573aafa7 |
||
---|---|---|
.. | ||
data | ||
test_framework | ||
.gitignore | ||
combine_logs.py | ||
combined_log_template.html | ||
create_cache.py | ||
example_test.py | ||
feature_abortnode.py | ||
feature_addressindex.py | ||
feature_asmap.py | ||
feature_assumevalid.py | ||
feature_bip68_sequence.py | ||
feature_block.py | ||
feature_blocksdir.py | ||
feature_cltv.py | ||
feature_config_args.py | ||
feature_csv_activation.py | ||
feature_dbcrash.py | ||
feature_dersig.py | ||
feature_dip3_deterministicmns.py | ||
feature_dip4_coinbasemerkleroots.py | ||
feature_dip0020_activation.py | ||
feature_fee_estimation.py | ||
feature_filelock.py | ||
feature_governance_objects.py | ||
feature_help.py | ||
feature_includeconf.py | ||
feature_llmq_chainlocks.py | ||
feature_llmq_connections.py | ||
feature_llmq_data_recovery.py | ||
feature_llmq_dkgerrors.py | ||
feature_llmq_is_cl_conflicts.py | ||
feature_llmq_is_migration.py | ||
feature_llmq_is_retroactive.py | ||
feature_llmq_rotation.py | ||
feature_llmq_signing.py | ||
feature_llmq_simplepose.py | ||
feature_loadblock.py | ||
feature_logging.py | ||
feature_maxuploadtarget.py | ||
feature_minchainwork.py | ||
feature_multikeysporks.py | ||
feature_new_quorum_type_activation.py | ||
feature_notifications.py | ||
feature_nulldummy.py | ||
feature_proxy.py | ||
feature_pruning.py | ||
feature_reindex.py | ||
feature_settings.py | ||
feature_shutdown.py | ||
feature_spentindex.py | ||
feature_sporks.py | ||
feature_timestampindex.py | ||
feature_txindex.py | ||
feature_uacomment.py | ||
feature_utxo_set_hash.py | ||
feature_versionbits_warning.py | ||
interface_bitcoin_cli.py | ||
interface_http.py | ||
interface_rest.py | ||
interface_rpc.py | ||
interface_zmq_dash.py | ||
interface_zmq.py | ||
mempool_accept.py | ||
mempool_expiry.py | ||
mempool_limit.py | ||
mempool_package_onemore.py | ||
mempool_packages.py | ||
mempool_persist.py | ||
mempool_reorg.py | ||
mempool_resurrect.py | ||
mempool_spend_coinbase.py | ||
mempool_unbroadcast.py | ||
mining_basic.py | ||
mining_getblocktemplate_longpoll.py | ||
mining_prioritisetransaction.py | ||
p2p_addrv2_relay.py | ||
p2p_blockfilters.py | ||
p2p_blocksonly.py | ||
p2p_compactblocks.py | ||
p2p_connect_to_devnet.py | ||
p2p_disconnect_ban.py | ||
p2p_fingerprint.py | ||
p2p_instantsend.py | ||
p2p_invalid_block.py | ||
p2p_invalid_locator.py | ||
p2p_invalid_messages.py | ||
p2p_invalid_tx.py | ||
p2p_leak_tx.py | ||
p2p_leak.py | ||
p2p_mempool.py | ||
p2p_node_network_limited.py | ||
p2p_permissions.py | ||
p2p_quorum_data.py | ||
p2p_sendheaders_compressed.py | ||
p2p_sendheaders.py | ||
p2p_timeouts.py | ||
p2p_unrequested_blocks.py | ||
README.md | ||
rpc_bind.py | ||
rpc_blockchain.py | ||
rpc_coinjoin.py | ||
rpc_decodescript.py | ||
rpc_deprecated.py | ||
rpc_deriveaddresses.py | ||
rpc_dumptxoutset.py | ||
rpc_fundrawtransaction_hd.py | ||
rpc_fundrawtransaction.py | ||
rpc_generateblock.py | ||
rpc_getblockfilter.py | ||
rpc_getblockstats.py | ||
rpc_getchaintips.py | ||
rpc_help.py | ||
rpc_invalidateblock.py | ||
rpc_masternode.py | ||
rpc_misc.py | ||
rpc_mnauth.py | ||
rpc_named_arguments.py | ||
rpc_net.py | ||
rpc_platform_filter.py | ||
rpc_preciousblock.py | ||
rpc_psbt.py | ||
rpc_quorum.py | ||
rpc_rawtransaction.py | ||
rpc_scantxoutset.py | ||
rpc_setban.py | ||
rpc_signmessage.py | ||
rpc_signrawtransaction.py | ||
rpc_txoutproof.py | ||
rpc_uptime.py | ||
rpc_users.py | ||
rpc_verifychainlock.py | ||
rpc_verifyislock.py | ||
rpc_whitelist.py | ||
test_runner.py | ||
tool_wallet.py | ||
wallet_abandonconflict.py | ||
wallet_avoidreuse.py | ||
wallet_backup.py | ||
wallet_balance.py | ||
wallet_basic.py | ||
wallet_coinbase_category.py | ||
wallet_create_tx.py | ||
wallet_createwallet.py | ||
wallet_disable.py | ||
wallet_dump.py | ||
wallet_encryption.py | ||
wallet_fallbackfee.py | ||
wallet_groups.py | ||
wallet_hd.py | ||
wallet_import_rescan.py | ||
wallet_import_with_label.py | ||
wallet_importmulti.py | ||
wallet_importprunedfunds.py | ||
wallet_keypool_hd.py | ||
wallet_keypool_topup.py | ||
wallet_keypool.py | ||
wallet_labels.py | ||
wallet_listreceivedby.py | ||
wallet_listsinceblock.py | ||
wallet_listtransactions.py | ||
wallet_multiwallet.py | ||
wallet_reorgsrestore.py | ||
wallet_resendwallettransactions.py | ||
wallet_startup.py | ||
wallet_txn_clone.py | ||
wallet_txn_doublespend.py | ||
wallet_upgradetohd.py | ||
wallet_watchonly.py |
Functional tests
Writing Functional Tests
Example test
The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.
Coverage
Running test/functional/test_runner.py
with the --coverage
argument tracks which RPCs are
called by the tests and prints a report of uncovered RPCs in the summary. This
can be used (along with the --extended
argument) to find out which RPCs we
don't have test cases for.
Style guidelines
- Where possible, try to adhere to PEP-8 guidelines
- Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
- The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
- See the python lint script that checks for violations that could lead to bugs and issues in the test code.
- Avoid wildcard imports
- Use a module-level docstring to describe what the test is testing, and how it is testing it.
- When subclassing the BitcoinTestFramwork, place overrides for the
set_test_params()
,add_options()
andsetup_xxxx()
methods at the top of the subclass, then locally-defined helper methods, then therun_test()
method. - Use
'{}'.format(x)
for string formatting, not'%s' % x
.
Naming guidelines
- Name the test
<area>_test.py
, where area can be one of the following:feature
for tests for full features that aren't wallet/mining/mempool, egfeature_rbf.py
interface
for tests for other interfaces (REST, ZMQ, etc), eginterface_rest.py
mempool
for tests for mempool behaviour, egmempool_reorg.py
mining
for tests for mining features, egmining_prioritisetransaction.py
p2p
for tests that explicitly test the p2p interface, egp2p_disconnect_ban.py
rpc
for tests for individual RPC methods or features, egrpc_listtransactions.py
tool
for tests for tools, egtool_wallet.py
wallet
for tests for wallet features, egwallet_keypool.py
- use an underscore to separate words
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
rpc_decodescript.py
, notrpc_decode_script.py
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
- Don't use the redundant word
test
in the name, eginterface_zmq.py
, notinterface_zmq_test.py
General test-writing advice
- Set
self.num_nodes
to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis). - Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
- Set the
self.setup_clean_chain
variable inset_test_params()
to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x500=12500 DASH) in its wallet. - When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
- Many of the core test framework classes such as
CBlock
andCTransaction
don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.
RPC and P2P definitions
Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:
/src/rpc/*
for RPCs/src/wallet/rpc*
for wallet RPCsProcessMessage()
in/src/net_processing.cpp
for parsing P2P messages
Using the P2P interface
-
messages.py contains all the definitions for objects that pass over the network (
CBlock
,CTransaction
, etc, along with the network-level wrappers for them,msg_block
,msg_tx
, etc). -
P2P tests have two threads. One thread handles all network communication with the dashd(s) being tested in a callback-based event loop; the other implements the test logic.
-
P2PConnection
is the class used to connect to a dashd.P2PInterface
contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods. -
Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.
Test framework modules
The following are useful modules for test developers. They are located in test/functional/test_framework/.
authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework.py
Base class for functional tests.
util.py
Generally useful functions.
mininode.py
Basic code to support P2P connectivity to a dashd.
script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
key.py
Test-only secp256k1 elliptic curve implementation
blocktools.py
Helper functions for creating blocks and transactions.
Benchmarking with perf
An easy way to profile node performance during functional tests is provided
for Linux platforms using perf
.
Perf will sample the running node and will generate profile data in the node's
datadir. The profile data can then be presented using perf report
or a graphical
tool like hotspot.
There are two ways of invoking perf: one is to use the --perf
flag when
running tests, which will profile each node during the entire test run: perf
begins to profile when the node starts and ends when it shuts down. The other
way is the use the profile_with_perf
context manager, e.g.
with node.profile_with_perf("send-big-msgs"):
# Perform activity on the node you're interested in profiling, e.g.:
for _ in range(10000):
node.p2p.send_message(some_large_message)
To see useful textual output, run
perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less
See also:
- Installing perf
- Perf examples
- Hotspot: a GUI for perf output analysis