mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
4774e1e8f6
b4511e2e2ed1a6077ae6826a9ee6b7a311293d08 log: Prefix log messages with function name if -logsourcelocations is set (practicalswift)
Pull request description:
Prefix log messages with function name if `-logfunctionnames` is set.
Yes, exactly like `-logthreadnames` but for function names instead of thread names :)
This is a small developer ergonomics improvement: I've found this to be a cheap/simple way to correlate log output and originating function.
For me it beats the ordinary cycle of 1.) try to figure out a regexp matching the static part of the dynamic log message, 2.) `git grep -E 'Using .* MiB out of .* requested for signature cache'`, 3.) `mcedit filename.cpp` (`openemacs filename.cpp` works too!) and 4.) search for log message and scroll up to find the function name :)
Without any logging parameters:
```
$ src/bitcoind -regtest
2020-08-25T03:29:04Z Using RdRand as an additional entropy source
2020-08-25T03:29:04Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2020-08-25T03:29:04Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2020-08-25T03:29:04Z Loaded best chain: hashBestChain=0fff88f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e22ff height=0 date=2011-02-02T23:16:42Z progress=1.000000
2020-08-25T03:29:04Z block tree size = 1
2020-08-25T03:29:04Z nBestHeight = 0
2020-08-25T03:29:04Z Imported mempool transactions from disk: 0 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2020-08-25T03:29:04Z 0 addresses found from DNS seeds
```
With `-logthreadnames` and `-logfunctionnames`:
```
$ src/bitcoind -regtest -logthreadnames -logfunctionnames
2020-08-25T03:29:04Z [init] [ReportHardwareRand] Using RdRand as an additional entropy source
2020-08-25T03:29:04Z [init] [InitSignatureCache] Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2020-08-25T03:29:04Z [init] [InitScriptExecutionCache] Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2020-08-25T03:29:04Z [init] [LoadChainTip] Loaded best chain: hashBestChain=0fff88f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e22ff height=0 date=2011-02-02T23:16:42Z progress=1.000000
2020-08-25T03:29:04Z [init] [AppInitMain] block tree size = 1
2020-08-25T03:29:04Z [init] [AppInitMain] nBestHeight = 0
2020-08-25T03:29:04Z [loadblk] [LoadMempool] Imported mempool transactions from disk: 0 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2020-08-25T03:29:04Z [dnsseed] [ThreadDNSAddressSeed] 0 addresses found from DNS seeds
```
ACKs for top commit:
laanwj:
Code review ACK b4511e2e2ed1a6077ae6826a9ee6b7a311293d08
MarcoFalke:
review ACK b4511e2e2ed1a6077ae6826a9ee6b7a311293d08 🌃
Tree-SHA512: d100f5364630c323f31d275259864c597f7725e462d5f4bdedcc7033ea616d7fc0d16ef1b2af557e692f4deea73c6773ccfc681589e7bf6ba970b9ec169040c7
234 lines
8.3 KiB
C++
234 lines
8.3 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_LOGGING_H
|
|
#define BITCOIN_LOGGING_H
|
|
|
|
#include <fs.h>
|
|
#include <tinyformat.h>
|
|
#include <threadsafety.h>
|
|
#include <util/string.h>
|
|
|
|
#include <atomic>
|
|
#include <cstdint>
|
|
#include <list>
|
|
#include <mutex>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
static const bool DEFAULT_LOGTIMEMICROS = false;
|
|
static const bool DEFAULT_LOGIPS = false;
|
|
static const bool DEFAULT_LOGTIMESTAMPS = true;
|
|
static const bool DEFAULT_LOGTHREADNAMES = false;
|
|
static const bool DEFAULT_LOGSOURCELOCATIONS = false;
|
|
extern const char * const DEFAULT_DEBUGLOGFILE;
|
|
|
|
extern bool fLogThreadNames;
|
|
extern bool fLogIPs;
|
|
|
|
struct LogCategory {
|
|
std::string category;
|
|
bool active;
|
|
};
|
|
|
|
namespace BCLog {
|
|
enum LogFlags : uint64_t {
|
|
NONE = 0,
|
|
NET = (1 << 0),
|
|
TOR = (1 << 1),
|
|
MEMPOOL = (1 << 2),
|
|
HTTP = (1 << 3),
|
|
BENCHMARK = (1 << 4),
|
|
ZMQ = (1 << 5),
|
|
WALLETDB = (1 << 6),
|
|
RPC = (1 << 7),
|
|
ESTIMATEFEE = (1 << 8),
|
|
ADDRMAN = (1 << 9),
|
|
SELECTCOINS = (1 << 10),
|
|
REINDEX = (1 << 11),
|
|
CMPCTBLOCK = (1 << 12),
|
|
RANDOM = (1 << 13),
|
|
PRUNE = (1 << 14),
|
|
PROXY = (1 << 15),
|
|
MEMPOOLREJ = (1 << 16),
|
|
LIBEVENT = (1 << 17),
|
|
COINDB = (1 << 18),
|
|
QT = (1 << 19),
|
|
LEVELDB = (1 << 20),
|
|
VALIDATION = (1 << 21),
|
|
I2P = (1 << 22),
|
|
LOCK = (1 << 24),
|
|
|
|
//Start Dash
|
|
CHAINLOCKS = ((uint64_t)1 << 32),
|
|
GOBJECT = ((uint64_t)1 << 33),
|
|
INSTANTSEND = ((uint64_t)1 << 34),
|
|
LLMQ = ((uint64_t)1 << 36),
|
|
LLMQ_DKG = ((uint64_t)1 << 37),
|
|
LLMQ_SIGS = ((uint64_t)1 << 38),
|
|
MNPAYMENTS = ((uint64_t)1 << 39),
|
|
MNSYNC = ((uint64_t)1 << 40),
|
|
COINJOIN = ((uint64_t)1 << 41),
|
|
SPORK = ((uint64_t)1 << 42),
|
|
NETCONN = ((uint64_t)1 << 43),
|
|
EHF = ((uint64_t)1 << 44),
|
|
CREDITPOOL = ((uint64_t)1 << 45),
|
|
|
|
DASH = CHAINLOCKS | GOBJECT | INSTANTSEND | LLMQ | LLMQ_DKG
|
|
| LLMQ_SIGS | MNPAYMENTS | MNSYNC | COINJOIN | SPORK | NETCONN
|
|
| EHF | CREDITPOOL,
|
|
|
|
NET_NETCONN = NET | NETCONN, // use this to have something logged in NET and NETCONN as well
|
|
//End Dash
|
|
|
|
ALL = ~(uint64_t)0,
|
|
};
|
|
|
|
class Logger
|
|
{
|
|
private:
|
|
mutable StdMutex m_cs; // Can not use Mutex from sync.h because in debug mode it would cause a deadlock when a potential deadlock was detected
|
|
|
|
FILE* m_fileout GUARDED_BY(m_cs) = nullptr;
|
|
std::list<std::string> m_msgs_before_open GUARDED_BY(m_cs);
|
|
bool m_buffering GUARDED_BY(m_cs) = true; //!< Buffer messages before logging can be started.
|
|
|
|
/**
|
|
* m_started_new_line is a state variable that will suppress printing of
|
|
* the timestamp when multiple calls are made that don't end in a
|
|
* newline.
|
|
*/
|
|
std::atomic_bool m_started_new_line{true};
|
|
|
|
/** Log categories bitfield. */
|
|
std::atomic<uint64_t> m_categories{0};
|
|
|
|
std::string LogTimestampStr(const std::string& str);
|
|
std::string LogThreadNameStr(const std::string &str);
|
|
|
|
/** Slots that connect to the print signal */
|
|
std::list<std::function<void(const std::string&)>> m_print_callbacks /* GUARDED_BY(m_cs) */ {};
|
|
|
|
public:
|
|
bool m_print_to_console = false;
|
|
bool m_print_to_file = false;
|
|
|
|
bool m_log_timestamps = DEFAULT_LOGTIMESTAMPS;
|
|
bool m_log_time_micros = DEFAULT_LOGTIMEMICROS;
|
|
bool m_log_threadnames = DEFAULT_LOGTHREADNAMES;
|
|
bool m_log_sourcelocations = DEFAULT_LOGSOURCELOCATIONS;
|
|
|
|
fs::path m_file_path;
|
|
std::atomic<bool> m_reopen_file{false};
|
|
|
|
/** Send a string to the log output */
|
|
void LogPrintStr(const std::string& str, const std::string& logging_function, const std::string& source_file, const int source_line);
|
|
|
|
/** Returns whether logs will be written to any output */
|
|
bool Enabled() const
|
|
{
|
|
StdLockGuard scoped_lock(m_cs);
|
|
return m_buffering || m_print_to_console || m_print_to_file || !m_print_callbacks.empty();
|
|
}
|
|
|
|
/** Connect a slot to the print signal and return the connection */
|
|
std::list<std::function<void(const std::string&)>>::iterator PushBackCallback(std::function<void(const std::string&)> fun)
|
|
{
|
|
StdLockGuard scoped_lock(m_cs);
|
|
m_print_callbacks.push_back(std::move(fun));
|
|
return --m_print_callbacks.end();
|
|
}
|
|
|
|
/** Delete a connection */
|
|
void DeleteCallback(std::list<std::function<void(const std::string&)>>::iterator it)
|
|
{
|
|
StdLockGuard scoped_lock(m_cs);
|
|
m_print_callbacks.erase(it);
|
|
}
|
|
|
|
/** Start logging (and flush all buffered messages) */
|
|
bool StartLogging();
|
|
/** Only for testing */
|
|
void DisconnectTestLogger();
|
|
|
|
void ShrinkDebugFile();
|
|
|
|
uint64_t GetCategoryMask() const { return m_categories.load(); }
|
|
|
|
void EnableCategory(LogFlags flag);
|
|
bool EnableCategory(const std::string& str);
|
|
void DisableCategory(LogFlags flag);
|
|
bool DisableCategory(const std::string& str);
|
|
|
|
bool WillLogCategory(LogFlags category) const;
|
|
/** Returns a vector of the log categories in alphabetical order. */
|
|
std::vector<LogCategory> LogCategoriesList(bool enabled_only = false) const;
|
|
/** Returns a string with the log categories in alphabetical order. */
|
|
std::string LogCategoriesString(bool enabled_only = false) const
|
|
{
|
|
return Join(LogCategoriesList(enabled_only), ", ", [&](const LogCategory& i) { return i.category; });
|
|
};
|
|
|
|
bool DefaultShrinkDebugFile() const;
|
|
};
|
|
|
|
} // namespace BCLog
|
|
|
|
BCLog::Logger& LogInstance();
|
|
|
|
/** Return true if log accepts specified category */
|
|
static inline bool LogAcceptCategory(BCLog::LogFlags category)
|
|
{
|
|
return LogInstance().WillLogCategory(category);
|
|
}
|
|
|
|
/** Return true if str parses as a log category and set the flag */
|
|
bool GetLogCategory(BCLog::LogFlags& flag, const std::string& str);
|
|
|
|
/** Formats a string without throwing exceptions. Instead, it'll return an error string instead of formatted string. */
|
|
template<typename... Args>
|
|
std::string SafeStringFormat(const std::string& fmt, const Args&... args)
|
|
{
|
|
try {
|
|
return tinyformat::format(fmt, args...);
|
|
} catch (std::runtime_error& fmterr) {
|
|
std::string message = tinyformat::format("\n****TINYFORMAT ERROR****\n err=\"%s\"\n fmt=\"%s\"\n", fmterr.what(), fmt);
|
|
tfm::format(std::cerr, "%s", message);
|
|
return message;
|
|
}
|
|
}
|
|
|
|
// Be conservative when using LogPrintf/error or other things which
|
|
// unconditionally log to debug.log! It should not be the case that an inbound
|
|
// peer can fill up a user's disk with debug.log entries.
|
|
|
|
template <typename... Args>
|
|
static inline void LogPrintf_(const std::string& logging_function, const std::string& source_file, const int source_line, const char* fmt, const Args&... args)
|
|
{
|
|
if (LogInstance().Enabled()) {
|
|
std::string log_msg;
|
|
try {
|
|
log_msg = tfm::format(fmt, args...);
|
|
} catch (tinyformat::format_error& fmterr) {
|
|
/* Original format string will have newline so don't add one here */
|
|
log_msg = "Error \"" + std::string(fmterr.what()) + "\" while formatting log message: " + fmt;
|
|
}
|
|
LogInstance().LogPrintStr(log_msg, logging_function, source_file, source_line);
|
|
}
|
|
}
|
|
|
|
#define LogPrintf(...) LogPrintf_(__func__, __FILE__, __LINE__, __VA_ARGS__)
|
|
|
|
// Use a macro instead of a function for conditional logging to prevent
|
|
// evaluating arguments when logging for the category is not enabled.
|
|
#define LogPrint(category, ...) \
|
|
do { \
|
|
if (LogAcceptCategory((category))) { \
|
|
LogPrintf(__VA_ARGS__); \
|
|
} \
|
|
} while (0)
|
|
|
|
#endif // BITCOIN_LOGGING_H
|