Wladimir J. van der Laan 6ca09aaae3 Merge #9753: Add static_assert to prevent VARINT(<signed value>) ... 499d95e27 Add static_assert to prevent VARINT(<signed value>) (Russell Yanofsky) Pull request description: Using VARINT with signed types is dangerous because negative values will appear to serialize correctly, but then deserialize as positive values mod 128. This commit changes the VARINT macro to trigger a compile error by default if called with an signed value, and it updates existing broken uses of VARINT to pass a special flag that lets them keep working with no changes in behavior. There is some discussion about this issue here: https://github.com/bitcoin/bitcoin/pull/9693#issuecomment-278701473. I think another good change along these lines would be to make `GetSizeOfVarInt` and `WriteVarInt` throw exceptions if they are passed numbers less than 0 to serialize. But unlike this change, that would be a change in runtime behavior, and need more consideration. Tree-SHA512: 082c65598cfac6dc1da042bdb47dbc9d5d789fc849fe52921cc238578588f4e5ff976c8b4b2ce42cb75290eb14f3b42ea76e26202c223c5b2aa63ef45c2ea3cc		2020-12-17 15:20:31 +03:00
..
coinstats.cpp	Merge #9753: Add static_assert to prevent VARINT(<signed value>)	2020-12-17 15:20:31 +03:00
coinstats.h	Backporting Statoshi and bitcoin#16728 (#2515)	2020-12-15 10:22:23 -06:00