e3df910822
* Pass CCoinsView reference to special TX handling methods * Allow referencing other TX outputs for ProRegTx collateral * Remove "collateralAmount" from "protx register" * Rename "protx register" to "protx fund_register" * Remove UpdateSpork15Value from CDeterministicMNManager Was not used/implemented anymore * Lock masternode collaterals after chain/DIP3 is fully initialized Otherwise detection of collaterals does not work. * Implement new "protx register" RPC which uses existing collaterals * Remove "masternode info" RPC It is not consistent with other "masternode" RPCs anymore as it requires the ProRegTx hash while all other RPCs work with the collateral. * Load sporks from disk cache before initializing the chain Otherwise spork15 is not loaded when we check it for the first time. * Implement "protx info" RPC * Use "protx info" instead of "masternode info" in DIP3 tests * Test external collaterals for ProTx * Handle review comments * Don't pass CCoinView reference when it's not used * Revert "Pass CCoinsView reference to special TX handling methods" This reverts commit 28688724e112c8fe18e44aef055768dbbc068d7d. * Use GetUTXOCoin instead of now removed coinsView Also remove collateral height check as GetUTXOCoin only returns confirmed coins. * Add conflict handling for external collaterals to mempool * Handle review comments (squashed Github suggestions) Co-Authored-By: codablock <ablock84@gmail.com> |
||
---|---|---|
.. | ||
data | ||
addrman_tests.cpp | ||
alert_tests.cpp | ||
allocator_tests.cpp | ||
amount_tests.cpp | ||
arith_uint256_tests.cpp | ||
base32_tests.cpp | ||
base58_tests.cpp | ||
base64_tests.cpp | ||
bctest.py | ||
bip32_tests.cpp | ||
bip39_tests.cpp | ||
bitcoin-util-test.py | ||
blockencodings_tests.cpp | ||
bloom_tests.cpp | ||
bswap_tests.cpp | ||
buildenv.py.in | ||
cachemap_tests.cpp | ||
cachemultimap_tests.cpp | ||
checkqueue_tests.cpp | ||
coins_tests.cpp | ||
compress_tests.cpp | ||
crypto_tests.cpp | ||
cuckoocache_tests.cpp | ||
dbwrapper_tests.cpp | ||
DoS_tests.cpp | ||
evo_deterministicmns_tests.cpp | ||
evo_simplifiedmns_tests.cpp | ||
getarg_tests.cpp | ||
governance_validators_tests.cpp | ||
hash_tests.cpp | ||
key_tests.cpp | ||
limitedmap_tests.cpp | ||
main_tests.cpp | ||
Makefile | ||
mempool_tests.cpp | ||
merkle_tests.cpp | ||
miner_tests.cpp | ||
multisig_tests.cpp | ||
net_tests.cpp | ||
netbase_tests.cpp | ||
pmt_tests.cpp | ||
policyestimator_tests.cpp | ||
pow_tests.cpp | ||
prevector_tests.cpp | ||
raii_event_tests.cpp | ||
ratecheck_tests.cpp | ||
README.md | ||
reverselock_tests.cpp | ||
rpc_tests.cpp | ||
sanity_tests.cpp | ||
scheduler_tests.cpp | ||
script_P2PK_tests.cpp | ||
script_P2PKH_tests.cpp | ||
script_P2SH_tests.cpp | ||
script_tests.cpp | ||
scriptnum10.h | ||
scriptnum_tests.cpp | ||
serialize_tests.cpp | ||
sighash_tests.cpp | ||
sigopcount_tests.cpp | ||
skiplist_tests.cpp | ||
streams_tests.cpp | ||
subsidy_tests.cpp | ||
test_dash.cpp | ||
test_dash.h | ||
test_random.h | ||
testutil.cpp | ||
testutil.h | ||
timedata_tests.cpp | ||
transaction_tests.cpp | ||
txvalidationcache_tests.cpp | ||
uint256_tests.cpp | ||
univalue_tests.cpp | ||
util_tests.cpp | ||
versionbits_tests.cpp |
Compiling/running unit tests
Unit tests will be automatically compiled if dependencies were met in ./configure
and tests weren't explicitly disabled.
After configuring, they can be run with make check
.
To run the dashd tests manually, launch src/test/test_dash
.
To add more dashd tests, add BOOST_AUTO_TEST_CASE
functions to the existing
.cpp files in the test/
directory or add new .cpp files that
implement new BOOST_AUTO_TEST_SUITE sections.
To run the dash-qt tests manually, launch src/qt/test/test_dash-qt
To add more dash-qt tests, add them to the src/qt/test/
directory and
the src/qt/test/test_main.cpp
file.
Running individual tests
test_dash has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:
test_dash --log_level=all --run_test=getarg_tests
... or to run just the doubledash test:
test_dash --run_test=getarg_tests/doubledash
Run test_dash --help
for the full list.
Note on adding test cases
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Dash Core already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).
The build system is setup to compile an executable called test_dash
that runs all of the unit tests. The main source file is called
test_dash.cpp. To add a new unit test file to our test suite you need
to add the file to src/Makefile.test.include
. The pattern is to create
one test file for each class or source file for which you want to create
unit tests. The file naming convention is <source_filename>_tests.cpp
and such files should wrap their tests in a test suite
called <source_filename>_tests
. For an example of this pattern,
examine uint256_tests.cpp
.
For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.
bitcoin-util-test.py
The test directory also contains the bitcoin-util-test.py tool, which tests bitcoin utils (currently just dash-tx). This test gets run automatically during the make check
build process. It is also possible to run the test manually from the src directory:
test/bitcoin-util-test.py --srcdir=[current directory]