8ea40102c0
* Remove leftover RBF code from BTC * remove rbf #include * remove rbf in rpc-tests * removes replace-by-fee.py * remove help text related to rbf * remove comment text relating to rbf * remove "-mempoolreplacement" cli option * Remove (effectively dead) RBF code which would never have been called anyway and some assosiated variables * since `setConflicts` is always empty, this is dead code * Since we don't have RBF, don't have to do this check. Also, since `setConflicts` is always empty this is dead code * removes unneccesary if as it will always be true * remove unused `set<uint256> setConflicts` * Removes replacement of conflicting txs, as conflicting txs are never accepted * removes RBF from `validForFeeEstimation` * removes (probably) unnecessary lock * remove replacing part of the AcceptToMemoryPool and AcceptToMemoryPoolWIthTime * fixes err in ps.cpp, didn't remove arg * RBF in net_processing.cpp * remove arg in ps-server.cpp * removes another arg in PS code * removes rawtx.c AcceptToMemoryPool arg * removes arg in txvalidationcache_tests.cpp * remove extra args * forgot an arg * fix typo in 82898b0 * remove unused fEnableReplacement in validation.h * remove the removal reason REPLACED in txmempool.h * removed unused variable * comment typo
88 lines
3.0 KiB
C++
88 lines
3.0 KiB
C++
// Copyright (c) 2011-2015 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include "consensus/validation.h"
|
|
#include "key.h"
|
|
#include "validation.h"
|
|
#include "miner.h"
|
|
#include "pubkey.h"
|
|
#include "txmempool.h"
|
|
#include "random.h"
|
|
#include "script/standard.h"
|
|
#include "test/test_dash.h"
|
|
#include "utiltime.h"
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
BOOST_AUTO_TEST_SUITE(tx_validationcache_tests)
|
|
|
|
static bool
|
|
ToMemPool(CMutableTransaction& tx)
|
|
{
|
|
LOCK(cs_main);
|
|
|
|
CValidationState state;
|
|
return AcceptToMemoryPool(mempool, state, MakeTransactionRef(tx), false, NULL, true, 0);
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)
|
|
{
|
|
// Make sure skipping validation of transctions that were
|
|
// validated going into the memory pool does not allow
|
|
// double-spends in blocks to pass validation when they should not.
|
|
|
|
CScript scriptPubKey = CScript() << ToByteVector(coinbaseKey.GetPubKey()) << OP_CHECKSIG;
|
|
|
|
// Create a double-spend of mature coinbase txn:
|
|
std::vector<CMutableTransaction> spends;
|
|
spends.resize(2);
|
|
for (int i = 0; i < 2; i++)
|
|
{
|
|
spends[i].nVersion = 1;
|
|
spends[i].vin.resize(1);
|
|
spends[i].vin[0].prevout.hash = coinbaseTxns[0].GetHash();
|
|
spends[i].vin[0].prevout.n = 0;
|
|
spends[i].vout.resize(1);
|
|
spends[i].vout[0].nValue = 11*CENT;
|
|
spends[i].vout[0].scriptPubKey = scriptPubKey;
|
|
|
|
// Sign:
|
|
std::vector<unsigned char> vchSig;
|
|
uint256 hash = SignatureHash(scriptPubKey, spends[i], 0, SIGHASH_ALL);
|
|
BOOST_CHECK(coinbaseKey.Sign(hash, vchSig));
|
|
vchSig.push_back((unsigned char)SIGHASH_ALL);
|
|
spends[i].vin[0].scriptSig << vchSig;
|
|
}
|
|
|
|
CBlock block;
|
|
|
|
// Test 1: block with both of those transactions should be rejected.
|
|
block = CreateAndProcessBlock(spends, scriptPubKey);
|
|
BOOST_CHECK(chainActive.Tip()->GetBlockHash() != block.GetHash());
|
|
|
|
// Test 2: ... and should be rejected if spend1 is in the memory pool
|
|
BOOST_CHECK(ToMemPool(spends[0]));
|
|
block = CreateAndProcessBlock(spends, scriptPubKey);
|
|
BOOST_CHECK(chainActive.Tip()->GetBlockHash() != block.GetHash());
|
|
mempool.clear();
|
|
|
|
// Test 3: ... and should be rejected if spend2 is in the memory pool
|
|
BOOST_CHECK(ToMemPool(spends[1]));
|
|
block = CreateAndProcessBlock(spends, scriptPubKey);
|
|
BOOST_CHECK(chainActive.Tip()->GetBlockHash() != block.GetHash());
|
|
mempool.clear();
|
|
|
|
// Final sanity test: first spend in mempool, second in block, that's OK:
|
|
std::vector<CMutableTransaction> oneSpend;
|
|
oneSpend.push_back(spends[0]);
|
|
BOOST_CHECK(ToMemPool(spends[1]));
|
|
block = CreateAndProcessBlock(oneSpend, scriptPubKey);
|
|
BOOST_CHECK(chainActive.Tip()->GetBlockHash() == block.GetHash());
|
|
// spends[1] should have been removed from the mempool when the
|
|
// block with spends[0] is accepted:
|
|
BOOST_CHECK_EQUAL(mempool.size(), 0);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|