Commit Graph

14885 Commits

Author SHA1 Message Date
UdjinM6
2474d9cb8c
Sync mn list and mnw list from 3 peers max (#2169)
Should solve issues with initial sync and reduce load/bandwidth in general.
2018-07-08 00:19:54 +03:00
Alexander Block
2c303cdb11 A few devnet related fixes (#2168)
* Remove testnet seeds from devnet

* Lift multiple ports restriction on devnet when considering new nodes

Allow to connect to multiple nodes behind the same IP

* Don't skip addresses with non-default port if it matches -port

If the user specified -port, he very likely intends to connect to nodes
with the same port.

* Don't pass false to CAddrMan constructor as it is already the default

* Make if statements easier to read
2018-07-08 00:19:33 +03:00
UdjinM6
050cabdf52
Adjust diff for slow testnet/devnet blocks a bit smoother (#2161)
* Adjust diff for slow testnet/devnet blocks a bit smoother

* bump to 000000000000000000000000000000000000000000000000003ff00000000000

* bump slow blocks to 10 minutes
2018-07-08 00:19:01 +03:00
PaulieD
c4698d5f3d Make PS Buttons not react to spacebar (#2154)
* Make the togglePrivateSend button not react to the spacebar or enter. #1766

* redo comment

* change `privateSendAuto` focus policy to remain consistent
2018-07-08 00:18:29 +03:00
UdjinM6
f833e2ed6c
Bump to 0.12.3.2 (#2173) 2018-07-08 00:17:36 +03:00
UdjinM6
1deab35186
Merge pull request #2159 from UdjinM6/mergetomaster1231
Merge develop 0.12.3.1 into master
2018-07-01 01:43:22 +03:00
UdjinM6
eebfa7986b Merge branch 'develop' into mergetomaster1231 2018-07-01 01:06:00 +03:00
UdjinM6
cf0ef9e63c
Bump to 0.12.3.1 (#2158)
* update release notes

* Bump to 0.12.3.1

* update Doxyfile
2018-06-30 23:39:49 +03:00
UdjinM6
a80ef04238
Update release notes (#2155)
* Update release notes

* add 2157
2018-06-30 22:29:25 +03:00
UdjinM6
fda74b4a8c
Use correct protocol when serializing messages in reply to getdata (#2157)
Messages should be serialized according the protocol of the peer who asked us or otherwise peers running on other protocols won't be able to deserialize the message correctly.
2018-06-30 21:18:37 +03:00
Kamil Woźniak
4dbde218b9 Fix p2pkh tests asserts (#2153)
Even the results were as expected,
IsPayToPublicKeyHash() breaks at size checking step now, as was intended.
Also removes compile time array-bounds warning.
2018-06-29 01:23:25 +03:00
UdjinM6
26c891f67f
Fix block value/payee validation in lite mode (#2148) 2018-06-29 01:23:06 +03:00
UdjinM6
7ab5b4a28e
Update/optimize images (#2147)
* update optimize-pngs.py with new paths

* `python contrib/devtools/optimize-pngs.py`

Total reduction: 22025 bytes

* update share/pixmaps/*
2018-06-29 01:22:48 +03:00
UdjinM6
5e1149a655
Update release notes (#2142)
* Update release notes

* add 2145
2018-06-24 22:05:54 +03:00
UdjinM6
9af9d57b41
Release 0.12.3 (#2145)
CLIENT_VERSION_IS_RELEASE false->true
2018-06-24 21:21:56 +03:00
InhumanPerfection
0d5426343d Fix an edge case in PrepareDenominate (#2138)
* PrepareDenominate fix

* Fix conditions
2018-06-22 18:57:46 +03:00
UdjinM6
8e6364694f
Bump SERIALIZATION_VERSION_STRINGs (#2136)
This is needed to ensure masternode and governance cache cleanup on migration.
2018-06-19 18:48:16 +03:00
UdjinM6
d46dc0f56c
Update release notes (#2135) 2018-06-19 13:57:48 +03:00
PaulieD
700b7ceb73 RPC: dumphdinfo should throw an error when wallet isn't HD (#2134)
* Throws an RPCError `RPC_WALLET_ERROR` when the command `dumphdinfo` is called and the wallet is not HD

* Refactor based on @Udjin's post
2018-06-19 08:52:32 +03:00
UdjinM6
6410705211
Fix 2 small issues in sporks module (#2133)
* Fix a crash when someone tries to update sporks without specifying `sporkkey`

Before:
Crashes with `Assertion failed: (fValid), function GetPubKey, file key.cpp, line 156.`

After:
Fails and prints rpc help for `spork`

* Silence logging in CSporkMessage::CheckSignature() a bit

CMessageSigner::VerifyMessage() failure is not really an error
if CHashSigner::VerifyHash() below passes with no issues.
No need to log this.
2018-06-19 02:40:55 +03:00
UdjinM6
6bf389afb8
Don't drop mnb-s for outdated MNs (#2131)
Instead just mark them as MASTERNODE_UPDATE_REQUIRED and proceed further.
2018-06-19 02:40:38 +03:00
UdjinM6
97b9b4fedc
Bump nMinimumChainWork, defaultAssumeValid and checkpoints (#2130) 2018-06-19 02:40:10 +03:00
UdjinM6
1c9917e227
Fix CVE-2018-12356 by hardening the regex (#2126) 2018-06-18 19:08:27 +03:00
UdjinM6
b7c326115e
Do not create mnb until sync is finished (#2122)
We don't relay mnb if sync is still in progress. Creating mnb without
relaying it only increases inconsistency and leads to user confusion.
Unifying conditions for creation and relaying fixes this.
2018-06-18 19:08:00 +03:00
UdjinM6
b98643c27d
Split sentinel expiration in CMasternode::Check() in two parts (timeout and version) (#2121)
The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state
while they should really be in PRE_ENABLED state. The fix is to split this verification
in two parts - this way sentinel version is only checked after at least one ping is received
from the masternode itself and not from the cold wallet.
2018-06-18 19:07:34 +03:00
UdjinM6
5669fc880e
Fix typos and rpc help text (#2120)
* Fix typo in PS info dialog

Also adjust translations accordingly.

* Fix typo in PS low key warning

* Fix typo in sendrawtransaction help

* Fix sendtoaddress/sendmany help text

* Fix listreceivedby* help text

* Fix typo in listunspent help

* Fix spelling "recieves"->"receives"

Shame on me

* transactions->transaction

* receives->"incoming payments grouped"
2018-06-18 19:07:09 +03:00
UdjinM6
d076ad4cea
Update release notes and staging tree in README (#2116)
* Update release notes

* add 2118

* bump staging tree in README.md
2018-06-12 22:10:36 +03:00
UdjinM6
806d7f0496
Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
UdjinM6
836e104710
Bump proto to 70210 (#2109) 2018-06-12 14:33:41 +03:00
UdjinM6
8d8fdb4339
sendrawtransaction no longer bypasses transaction policy limits by default (#2110)
* [rpc] sendrawtransaction no longer bypasses minRelayTxFee

The prioritisetransaction API can always be used if a transaction needs to be submitted that bypasses minRelayTxFee.

* Allow to bypass transaction policy limits in sendrawtransaction

Add new rpc param to sendrawtransaction to have an ability to tweak its behaviour.
Default is `false` i.e. "do not bypass".

* fix
2018-06-12 14:33:23 +03:00
UdjinM6
8e129877a6
Partially revert 1922 (#2108)
Turned out we actually need mixing collaterals charged as fees in our mempool for them to be relayed.
2018-06-11 13:14:41 +03:00
UdjinM6
8c2d16f5f3
Limit IS quorums by updated MNs only (#2107) 2018-06-11 13:14:24 +03:00
Semen Martynov
0a71c693e7 Remove explicit wallet lock in MasternodeList::StartAll() (#2106)
Possible fix #2104
2018-06-11 13:14:00 +03:00
UdjinM6
0de79d70b5
Do not create oversized transactions (bad-txns-oversize) (#2103) 2018-06-11 13:13:20 +03:00
UdjinM6
fcac40ab4e
RPC: fix wallet lock check in privatesend start (#2102) 2018-06-11 13:13:03 +03:00
UdjinM6
23ba94b370
Bump remaining min protocols (#2097)
* bump MIN_GOVERNANCE_PEER_PROTO_VERSION

* bump MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2
2018-06-06 19:06:52 +03:00
UdjinM6
6c79c348ee
Drop "MAY, 2018" clause for proposal validation on mainnet (#2101) 2018-06-06 19:06:23 +03:00
UdjinM6
6079b860e3
Drop trigger objects when triggers are deleted or failed to be created (#2098)
* Mark an object for deletion when the corresponding trigger is deleted

* Mark objects for deletion if creation of corresponding triggers failed

* NULL -> nullptr

* Make sure pObj is not null
2018-06-06 18:56:33 +03:00
UdjinM6
9299a84b1f
Bump few consts (#2096)
* bump BLOCK_CHAIN_SIZE

* bump nMinBlocksToStore default
2018-06-06 10:59:25 +03:00
UdjinM6
dbbedc031c
Fix JoinExistingQueue bug (#2100)
10s denoms were ignored due to the value overflow
2018-06-06 10:59:09 +03:00
Alexander Block
7b43720f05
Fix copying of final binaries into dashcore-binaries (#2090)
* Fix copying of final binaries into dashcore-binaries

* Fix binary names in gitian-osx-signer.yml and gitian-win-signer.yml
2018-05-31 17:31:00 +02:00
UdjinM6
ca2eae6e6e
12.3 release notes draft (#2045)
* 12.3 release notes draft

* update

* mn info dialog

* typo

* Minor additions and fixes

* A few additions

* Addressed reviews, rephrased, updated

* add recent commits

* more typos

* add recent commits

* Add recent commits

* add Chris Adam to credits for image work
2018-05-30 16:47:06 +03:00
Alexander Block
faeb4480a1 Update manpages with ./contrib/devtools/gen-manpages.sh (#2088) 2018-05-30 15:29:01 +03:00
Alexander Block
cc593615e1 Bump copyright year to 2018 (#2087) 2018-05-30 15:28:44 +03:00
Alexander Block
2129ee4d8c Add docker support when doing Gitian builds (#2084)
* gitian-build.sh: fix signProg being recognized as two parameters

* Support docker based Gitian builds

Requires a gitian-builder version with
https://github.com/devrandom/gitian-builder/pull/181

This will also switch to use Docker by default.

* Switch back to using lxc as default until upstream gitian-builder is ready
2018-05-30 13:48:30 +03:00
Alexander Block
6a1456ef4c Update gitian key for codablock (#2085)
https://keybase.io/codablock

Old key was using default gpg settings with 2048 bits.
2018-05-29 18:13:47 +03:00
Nathan Marley
82805a6c69 swap out old logo for T&C logo in Qt GUI (#2081)
* Qt: rename light theme to light-retro

* add new light theme with new logo images

* revert changes to light.css

* Qt: rename light-hires theme to light-hires-retro

* copy, not move

* restore light-hires.css

* all links updated from light to light-retro

* revert rm trailing spaces in src/qt/guiutil.cpp

* all links updated from light-hires to light-hires-retro
2018-05-29 18:13:08 +03:00
Alexander Block
ab96a6af63 Update gitian keys, script and doc (#2082)
* Remove Bitcoin Gitian keys

* Update gitian-build.sh and gitian-building.md

gitian-building.md referenced "br0" but "lxcbr0" was used in the script.
gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with
VirtualBox networking.

* Add gitian key for codablock

https://keybase.io/codablock

* Add gitian key for schinzelh

https://keybase.io/schinzelh

* Add gitian key for gladcow

https://keybase.io/gladcow

* Add gitian key for nmarley

https://keybase.io/nmarley

* Add gitian key for udjinm6

https://keybase.io/UdjinM6

* Add EOL chars
2018-05-26 21:04:07 +03:00
UdjinM6
c60079b594
ThreadOpenMasternodeConnections should process only one mn at a time (#2080) 2018-05-26 21:03:49 +03:00
UdjinM6
7ac4b972ab
Require all participants to submit equal number of inputs (#2075)
Activates via SPORK_6_NEW_SIGS to avoid nInputCount malleability
2018-05-26 21:03:23 +03:00