sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
37fbdee1d9
dash/src
History
pasta f9d044d5ec
Merge #6423: refactor: create helper function RelayRecoveredSig inside peerman 
86e92c376a refactor: drop unused CConnman from CSigningManager (Konstantin Akimov)
4668db60a2 refactor: create helper function RelayRecoveredSig inside peerman (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  High m_nodes_mutex lock contention during high load

  ## What was done?
  this commit should have a few benefits:
  1. previous logic using ForEachNode results in locking m_nodes_mutex, a highly contended RecursiveMutex, AND m_peer_mutex(in GetPeerRef)
  2. prior also resulted in calling .find over the m_peer_map for each node. Basically old logic was (probably) O(n(nlogn) the new logic results in acquiring m_peer_mutex once and looping over the list of peers, (probably) O(n)
  3. Moves networking logic out of llmq/ and into actual net_processing.cpp

  ## How Has This Been Tested?
  Hasn't really yet; it builds, but I need to run tests / maybe deploy to testnet mn

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK 86e92c376a
  UdjinM6:
    utACK 86e92c376a

Tree-SHA512: ca9d6ac22f8b72b117188147044c499ae62722283c6291633067b99726e6a6abc52e5c8cf3bdcd0d8fed0ad8d9086b000f628c9a932dfe89153e912b563eda5a
2024-11-22 16:27:31 -06:00
..
bench Merge bitcoin/bitcoin#24306: util: Make ArgsManager::GetPathArg more widely usable 2024-11-17 17:49:05 -06:00
bls refactor: Make bls worker aggregator batch size const (rename it accordingly) 2024-11-01 22:50:36 +03:00
coinjoin merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
common merge bitcoin#23137: move-only bloom to src/common 2024-10-25 21:36:52 +00:00
compat
config
consensus merge bitcoin#24565: Remove LOCKTIME_MEDIAN_TIME_PAST constant 2024-10-25 21:36:54 +00:00
crc32c Merge bitcoin/bitcoin#29493: subtree: update crc32c subtree 2024-10-24 11:16:20 -05:00
crypto Merge bitcoin/bitcoin#30097: crypto: disable asan for sha256_sse4 with clang and -O0 2024-10-25 15:30:56 -05:00
dashbls build: stop tracking cmake dependency relic_conf.h.in 2024-10-09 17:26:10 +03:00
evo refactor: set const auto& cbTx to avoid using optional throughout method 2024-11-20 03:20:50 +07:00
governance refactor: trim and document assumptions for Get*MN* and friends 2024-11-14 10:08:05 +00:00
gsl
immer build: drop symlinks in immer subtree 2024-11-02 20:19:50 +00:00
index Merge #6370: backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 (auxiliary backports: part 21) 2024-10-29 20:12:53 -05:00
init Merge bitcoin/bitcoin#24306: util: Make ArgsManager::GetPathArg more widely usable 2024-11-17 17:49:05 -06:00
interfaces refactor: more CGovernanceVote cleanups 2024-11-04 17:27:00 +03:00
ipc
leveldb
llmq Merge #6423: refactor: create helper function RelayRecoveredSig inside peerman 2024-11-22 16:27:31 -06:00
logging
masternode refactor: trim and document assumptions for Get*MN* and friends 2024-11-14 10:08:05 +00:00
minisketch depends: update 'src/minisketch' to sipa/minisketch@eb37a9b8 as ef10e83d 2024-10-29 10:16:07 +00:00
node Merge #6370: backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 (auxiliary backports: part 21) 2024-10-29 20:12:53 -05:00
policy merge bitcoin#24565: Remove LOCKTIME_MEDIAN_TIME_PAST constant 2024-10-25 21:36:54 +00:00
primitives merge bitcoin#24136: Extract CTxIn::MAX_SEQUENCE_NONFINAL constant, rework BIP 65/68/112 docs 2024-10-28 10:45:28 +00:00
qt Merge #6404: fix(qt): avoid potential precision loss in amounts on Governance Tab 2024-11-20 23:24:36 -06:00
rpc refactor: drop unused InstantSendManager from blockheaderToJSON 2024-11-16 17:44:31 +07:00
script merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
secp256k1
stats Merge #6312: chore: Update copyrights and copyright_header.py script 2024-10-07 15:29:29 -05:00
support Merge bitcoin/bitcoin#26950: cleanse: switch to SecureZeroMemory for Windows cross-compile 2024-10-26 19:14:07 -05:00
test Merge bitcoin/bitcoin#24371: util: Fix ReadBinaryFile reading beyond maxsize 2024-11-18 12:20:13 -06:00
univalue
util refactor: more of 24306 (GetPathArg in Dash-specific code) 2024-11-18 12:20:38 -06:00
wallet refactor: Use switch..case instead of if in AvailableCoins 2024-11-01 22:50:37 +03:00
zmq
.clang-format
addrdb.cpp
addrdb.h
addressindex.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
addressindex.h merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
addrman_impl.h
addrman.cpp Merge bitcoin/bitcoin#24312: addrman: Log too low compat value 2024-11-17 17:49:40 -06:00
addrman.h
arith_uint256.cpp
arith_uint256.h
attributes.h Merge bitcoin/bitcoin#27575: Introduce platform-agnostic ALWAYS_INLINE macro 2024-10-25 09:59:35 -05:00
banman.cpp
banman.h merge bitcoin#23137: move-only bloom to src/common 2024-10-25 21:36:52 +00:00
base58.cpp
base58.h
batchedlogger.cpp
batchedlogger.h
bech32.cpp Merge bitcoin/bitcoin#22579: doc: Add references for the generator/constant used in Bech32(m) 2024-10-04 14:59:02 +05:30
bech32.h
bip324.cpp
bip324.h
bitcoin-cli.cpp merge bitcoin#29212: Fix -netinfo backward compat with getpeerinfo pre-v26 2024-10-16 16:50:56 +00:00
bitcoin-tx.cpp
bitcoin-wallet.cpp
bitcoind.cpp
blockencodings.cpp
blockencodings.h
blockfilter.cpp Merge bitcoin/bitcoin#27010: refactor: use Hash helpers for double-SHA256 calculations 2024-10-25 09:08:28 -05:00
blockfilter.h merge bitcoin#24832: Verify the block filter hash when reading the filter from disk 2024-10-15 06:58:51 +00:00
cachemap.h
cachemultimap.h
chain.cpp
chain.h Merge bitcoin/bitcoin#28691: refactor: Remove CBlockFileInfo::SetNull 2024-10-24 13:50:32 -05:00
chainparams.cpp chore: update nMinimumChainWork, defaultAssumeValid, checkpointData, chainTxData for mainnet and testnet 2024-11-19 20:35:44 -06:00
chainparams.h refactor: pull LimitBlocksToTrace into CChainParams (reduce regtest to 100) 2024-10-29 12:53:47 -05:00
chainparamsbase.cpp feat: remove feature_dip0020_activationl.py functional test and related code 2024-10-08 15:20:40 +07:00
chainparamsbase.h
chainparamsseeds.h chore: update seeds 2024-11-20 11:33:06 -06:00
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp Merge bitcoin/bitcoin#25663: tracing: do not use coin after move in CCoinsViewCache::AddCoin 2024-10-24 11:21:49 -05:00
coins.h Merge bitcoin/bitcoin#28913: coins: make sure PoolAllocator uses the correct alignment 2024-10-23 22:19:56 -05:00
compat.h
compressor.cpp
compressor.h
context.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
core_io.h merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
core_memusage.h
core_read.cpp merge bitcoin#22875: Fix Racy ParseOpCode function initialization 2024-10-08 15:59:18 +00:00
core_write.cpp merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp feat: new fork WITHDRAWALS introduced 2024-10-08 03:15:53 +07:00
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dsnotificationinterface.cpp
dsnotificationinterface.h
dummywallet.cpp
flat-database.h refactor: Turn ReadResult into enum class 2024-11-01 22:50:36 +03:00
flatfile.cpp
flatfile.h Merge bitcoin/bitcoin#27289: Refactor: Remove unused FlatFilePos::SetNull 2024-10-24 15:16:39 -05:00
fs.cpp
fs.h
hash_x11.h fmt: run clang-format on hash_x11.h 2024-10-04 15:35:45 -05:00
hash.cpp partial bitcoin#19953: Implement BIP 340-342 validation 2024-10-27 19:38:29 +00:00
hash.h partial bitcoin#19953: Implement BIP 340-342 validation 2024-10-27 19:38:29 +00:00
httprpc.cpp
httprpc.h
httpserver.cpp
httpserver.h
i2p.cpp Merge #6346: backport: trivial 2024 10 23 pr2 2024-10-24 16:54:41 -05:00
i2p.h
indirectmap.h
init.cpp Merge bitcoin/bitcoin#24306: util: Make ArgsManager::GetPathArg more widely usable 2024-11-17 17:49:05 -06:00
init.h
key_io.cpp
key_io.h
key.cpp merge bitcoin#23595: Add ParseHex<std::byte>() helper 2024-10-29 07:52:53 +00:00
key.h merge bitcoin#23595: Add ParseHex<std::byte>() helper 2024-10-29 07:52:53 +00:00
limitedmap.h
logging.cpp merge bitcoin#23443: Erlay support signaling 2024-10-27 19:38:29 +00:00
logging.h merge bitcoin#23443: Erlay support signaling 2024-10-27 19:38:29 +00:00
Makefile.am merge bitcoin#29185: remove --enable-lto 2024-11-17 07:42:07 +00:00
Makefile.bench.include Merge #6321: backport: trivial 2024 10 08 2024-10-22 09:12:06 -05:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.minisketch.include merge bitcoin#29823: update subtree to 3472e2f5e 2024-10-29 10:09:02 +00:00
Makefile.qt_locale.include
Makefile.qt.include Merge bitcoin-core/gui#381: refactor: Make BitcoinCore class reusable 2024-10-25 20:51:20 +07:00
Makefile.qttest.include
Makefile.test_fuzz.include merge bitcoin#26497: Make ConsumeNetAddr always produce valid onion addresses 2024-10-26 19:22:31 +00:00
Makefile.test_util.include
Makefile.test.include merge bitcoin#23443: Erlay support signaling 2024-10-27 19:38:29 +00:00
Makefile.univalue.include
mapport.cpp Merge bitcoin/bitcoin#30283: upnp: fix build with miniupnpc 2.2.8 2024-10-26 19:14:05 -05:00
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h merge bitcoin#23137: move-only bloom to src/common 2024-10-25 21:36:52 +00:00
messagesigner.cpp
messagesigner.h
net_permissions.cpp
net_permissions.h
net_processing.cpp Merge #6423: refactor: create helper function RelayRecoveredSig inside peerman 2024-11-22 16:27:31 -06:00
net_processing.h refactor: create helper function RelayRecoveredSig inside peerman 2024-11-22 12:29:40 -06:00
net_types.cpp
net_types.h
net.cpp Merge #6365: backport: merge bitcoin#22778, #25156, #26497, #27213, #28189, #28155, #28895, partial bitcoin#26396 (networking backports: part 9) 2024-10-27 14:19:30 -05:00
net.h refactor: create helper function RelayRecoveredSig inside peerman 2024-11-22 12:29:40 -06:00
netaddress.cpp merge bitcoin#26497: Make ConsumeNetAddr always produce valid onion addresses 2024-10-26 19:22:31 +00:00
netaddress.h merge bitcoin#26497: Make ConsumeNetAddr always produce valid onion addresses 2024-10-26 19:22:31 +00:00
netbase.cpp Merge bitcoin/bitcoin#30245: net: Allow -proxy=[::1] on nodes with IPV6 lo only 2024-10-26 19:14:06 -05:00
netbase.h
netfulfilledman.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
netfulfilledman.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
netgroup.cpp Merge bitcoin/bitcoin#24976: netgroup: Follow-up for #22910 2024-10-15 09:25:09 -05:00
netgroup.h
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp merge bitcoin#23443: Erlay support signaling 2024-10-27 19:38:29 +00:00
protocol.h merge bitcoin#26359: Erlay support signaling follow-ups 2024-10-27 19:38:30 +00:00
psbt.cpp
psbt.h Merge bitcoin/bitcoin#26997: psbt: s/transcation/transaction/ 2024-10-23 20:06:32 -05:00
pubkey.cpp
pubkey.h
random.cpp Merge bitcoin/bitcoin#26839: Add support for RNDR/RNDRRS for AArch64 on Linux 2024-10-24 13:50:32 -05:00
random.h
randomenv.cpp Merge #6362: backport: trivial 2024 10 25 pr1 2024-10-27 14:15:08 -05:00
randomenv.h
rest.cpp refactor: drop unused InstantSendManager from blockheaderToJSON 2024-11-16 17:44:31 +07:00
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp
scheduler.h
serialize.h Merge bitcoin/bitcoin#28203: refactor: serialization simplifications 2024-10-24 11:18:38 -05:00
shutdown.cpp
shutdown.h
source_location.h
span.h
spentindex.h merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
spork.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
spork.h fix: adjust the number of spork defaults 2024-10-16 13:16:00 +03:00
stacktraces.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
stacktraces.h
streams.h merge bitcoin#16981: Improve runtime performance of --reindex 2024-10-15 06:58:52 +00:00
sync.cpp Merge #19668: Do not hide compile-time thread safety warnings 2024-10-12 20:06:28 +07:00
sync.h Merge #6319: backport: bitcoin#19668, #21598, #19979, #28774 - lock annotations 2024-10-21 09:08:38 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
timestampindex.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
tinyformat.h
torcontrol.cpp merge bitcoin#15423: Query Tor for correct -onion configuration 2024-10-29 07:52:53 +00:00
torcontrol.h merge bitcoin#15423: Query Tor for correct -onion configuration 2024-10-29 07:52:53 +00:00
txdb.cpp merge bitcoin#22626: Remove txindex migration code 2024-10-05 17:10:03 +00:00
txdb.h merge bitcoin#22626: Remove txindex migration code 2024-10-05 17:10:03 +00:00
txmempool.cpp fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
txmempool.h merge bitcoin#22951: move amount.h into consensus 2024-10-25 16:00:12 +00:00
txorphanage.cpp fix: fixes for orphange's locks and cs_main 2024-10-12 20:06:27 +07:00
txorphanage.h Merge bitcoin/bitcoin#21562: [net processing] Various tidying up of PeerManagerImpl ctor 2024-10-25 20:51:18 +07:00
uint256.cpp
uint256.h Merge bitcoin/bitcoin#27929: Added static_assert to check that base_blob is using whole bytes. 2024-10-25 09:12:01 -05:00
undo.h
unordered_lru_cache.h
validation.cpp refactor: Move HasChainLock() calls out of loops 2024-11-02 00:18:57 +03:00
validation.h Merge bitcoin/bitcoin#25677: refactor: make active_chain_tip a reference 2024-10-29 13:01:24 -05:00
validationinterface.cpp
validationinterface.h merge bitcoin#24138: Commit MuHash and best block together for coinstatsindex 2024-10-15 06:58:50 +00:00
version.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp
warnings.h